Feeling Lucky
?
[#3406] - [#33563] Make messages use JLayouts in Isis and Beez3
- Closed
- 24 May 2014
- Medium
- Build: staging
- # 3406
- Diff
- Bakual:MoveMessagesToLayouts
- Foreign ID 33563
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Based on discussions in #3389.
I rewrote the messages overrides for our core templates so they use the new JLayout as well.
Also standardised the conditionals a bit between those two overrides. Like changed (count($msgList) >= 1) to just $msgList which does the same.
Testing Instructions
Make sure messages are rendered the same before and after PR is applied. There should be no difference.
Tracker
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33563
| Title |
|
||||||
| Title |
|
||||||
mbabker
- comment
- 24 May 2014
Travis is fine, must have been a glitch on that particular run.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-05-24 19:51:06 |
test successfull (com_patchtester) and as @brianteeman test this also (see JC Tracker) This is RTC.
@Bakual i don't know why travis fails by this PR?