http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33555&start=0

As the only place typeAlias is being used is in the tags area https://github.com/infograf768/joomla-cms/blob/orderingnotice/libraries/legacy/model/admin.php#L1178 So rather than setting a $typeAlias for all scenario's - surely it would be better to move this if statement to cover the createTagsHelper function

@wilsonge
In the meanwhile, I updated PR as suggested by @elkuku

In fact the issue is indeed also for each batch functions, each time for createTagsHelper, $tagsobserver, etc.

Please wait for testing. Thomas is working on a global pr for all these issues.

@infograf768 second PR done against your branch,

• Changing if (!this->batchSet) to if (empty($this->batchSet)) so we don't get any notice if the property isn't set
• Wrapping the createTagsHelper into a conditional which checks for !empty($this->type)
• reverting my stupid moving the tag stuff into the foreach.

That looks much better :)

Before I merge, need to know if we keep static.
See infograf768#9

Looks OK now, need testers and comments on joomlacode. Thanks

test: The notice from the PHP error log is gone after applying the fix. Ordering still works as expected.

test. notice in my php error log stops appearing on reordering in module manager. But ordering still works. Code also looks good :)