User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Status | New | ⇒ | Pending |
Category | ⇒ | NPM Change |
is it expected that npm deletes 9,926 rows from package-lock.json?
is it expected that npm deletes 9,926 rows from package-lock.json?
All those that are removed are under the "packages" top level key.
we still have 50 vulnerabilities (43 moderate, 7 high) mostly due to the reliance on insecure out of date postcss
I have tested this item
Checked change log, no showstoppers. Applied PR. Rebuilt all assets, played with Joomla admin for a while. All seems to function.
is it expected that npm deletes 9,926 rows from package-lock.json?
@HLeithner That comes from the lock file format changing back from version 2 to version 1 ("lockfileVersion": 1
in line 4). Version 2 had lots of additional info like funding information. There still hasn't been made a decision if we change from 1 to 2. The reason why the 4.0-dev branch currently is 2 is because that might have happened with a past PR.
@wilsonge Correct me if that was all wrong what I wrote.
hmm at least it should be consistent and not changed with every pull request
Agree. But what can I do?
If memory serves me right then this is something the production department were going to make a decision on. Either way it doesnt prevent this being merged
@dgrammatiko can you please switch to type 2 format? so we don't jump between the formats?
I have no idea how this can be done. Let me google it
Its pointless
Its pointless
no idea why you think it's pointless but
Because if you look at the history you will see it switching between lockfile 1 and lockfile 2 repeatedly with no errors or issues. Its fine to make a ruling on which version to require but until that date ...
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-15 15:10:17 |
Closed_By | ⇒ | HLeithner | |
Labels |
Added:
NPM Resource Changed
?
|
thanks @dgrammatiko
right brian doesn't make sense when I'm the only maintainer that thinks about such things
So it turns out that version 2 is not what it's supposed to be here (it implies Node >= 14 && npm >= 7 which are not the project's minis)
A fix is to require everybody to use node>= 14 and npm >= 7
But, a nicer solution is to setup a simple github action that will automatically update the -lock.json (basically only the action will ever update the locks)
Solutions like:
https://stackoverflow.com/questions/64813775/is-there-any-way-to-fix-package-lock-json-lockfileversion-so-npm-uses-a-specific
will make things a lot more confusing for devs not familiar with nvm etc
https://blog.getbootstrap.com/2021/05/13/bootstrap-5-0-1/