NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
15 May 2021

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

avatar dgrammatiko dgrammatiko - open - 15 May 2021
avatar dgrammatiko dgrammatiko - change - 15 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 May 2021
Category NPM Change
avatar PhilETaylor
PhilETaylor - comment - 15 May 2021

https://blog.getbootstrap.com/2021/05/13/bootstrap-5-0-1/

Changelog
Fixed an issue where dropdowns wouldn’t close after clicking into an <input>
Validated inputs in .input-groups no longer render behind sibling elements
Prevent accent-bg from leaking in nested tables
Modal backdrops no longer throw Uncaught TypeError when initialized through JS
Refactored disposing properties into the base component
Extracted static DATA_KEY and EVENT_KEY to the base component
Merged transitionend listener callbacks into one method
Popovers and tooltips have a streamlined config property
Toasts no longer automatically hide on focus or hover
No longer redefining $list-group-color in the list group loop
avatar HLeithner
HLeithner - comment - 15 May 2021

is it expected that npm deletes 9,926 rows from package-lock.json?

avatar PhilETaylor
PhilETaylor - comment - 15 May 2021

is it expected that npm deletes 9,926 rows from package-lock.json?

All those that are removed are under the "packages" top level key.

we still have 50 vulnerabilities (43 moderate, 7 high) mostly due to the reliance on insecure out of date postcss

avatar PhilETaylor PhilETaylor - test_item - 15 May 2021 - Tested successfully
avatar PhilETaylor
PhilETaylor - comment - 15 May 2021

I have tested this item successfully on 8d43c3c

Checked change log, no showstoppers. Applied PR. Rebuilt all assets, played with Joomla admin for a while. All seems to function.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33901.

avatar richard67
richard67 - comment - 15 May 2021

is it expected that npm deletes 9,926 rows from package-lock.json?

@HLeithner That comes from the lock file format changing back from version 2 to version 1 ("lockfileVersion": 1in line 4). Version 2 had lots of additional info like funding information. There still hasn't been made a decision if we change from 1 to 2. The reason why the 4.0-dev branch currently is 2 is because that might have happened with a past PR.

@wilsonge Correct me if that was all wrong what I wrote.

avatar HLeithner
HLeithner - comment - 15 May 2021

hmm at least it should be consistent and not changed with every pull request

avatar richard67
richard67 - comment - 15 May 2021

Agree. But what can I do?

avatar brianteeman
brianteeman - comment - 15 May 2021

If memory serves me right then this is something the production department were going to make a decision on. Either way it doesnt prevent this being merged

avatar HLeithner
HLeithner - comment - 15 May 2021

@dgrammatiko can you please switch to type 2 format? so we don't jump between the formats?

avatar dgrammatiko
dgrammatiko - comment - 15 May 2021

I have no idea how this can be done. Let me google it

avatar brianteeman
brianteeman - comment - 15 May 2021

Its pointless

avatar HLeithner
HLeithner - comment - 15 May 2021

Its pointless

no idea why you think it's pointless but ?

avatar brianteeman
brianteeman - comment - 15 May 2021

Because if you look at the history you will see it switching between lockfile 1 and lockfile 2 repeatedly with no errors or issues. Its fine to make a ruling on which version to require but until that date ...

avatar HLeithner HLeithner - change - 15 May 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-15 15:10:17
Closed_By HLeithner
Labels Added: NPM Resource Changed ?
avatar HLeithner HLeithner - close - 15 May 2021
avatar HLeithner HLeithner - merge - 15 May 2021
avatar HLeithner
HLeithner - comment - 15 May 2021

thanks @dgrammatiko
right brian doesn't make sense when I'm the only maintainer that thinks about such things

avatar dgrammatiko
dgrammatiko - comment - 15 May 2021

So it turns out that version 2 is not what it's supposed to be here (it implies Node >= 14 && npm >= 7 which are not the project's minis)

A fix is to require everybody to use node>= 14 and npm >= 7
But, a nicer solution is to setup a simple github action that will automatically update the -lock.json (basically only the action will ever update the locks)

Solutions like:
https://stackoverflow.com/questions/64813775/is-there-any-way-to-fix-package-lock-json-lockfileversion-so-npm-uses-a-specific

will make things a lot more confusing for devs not familiar with nvm etc

Add a Comment

Login with GitHub to post a comment