? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
15 May 2021

This is the wrong approach and should not have been merged. You dont solve a responsive issue by adding a global class. please see #33899

By using the correct code you do not need to keep adding classes to buttons. Using only #33899 this is fixed correctly

avatar brianteeman brianteeman - open - 15 May 2021
avatar brianteeman brianteeman - change - 15 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 May 2021
Category Administration com_postinstall
avatar richard67 richard67 - change - 15 May 2021
Title
[4.0] Revert changes in #33717
[4.0] Revert changes in #33893
avatar richard67 richard67 - edited - 15 May 2021
avatar richard67
richard67 - comment - 15 May 2021

@brianteeman I was so free to change the title so it refers to the PR to be reverted and not to the issue.

avatar brianteeman
brianteeman - comment - 15 May 2021

oops - thanks - I copy pasted the title

avatar richard67 richard67 - test_item - 15 May 2021 - Tested successfully
avatar richard67
richard67 - comment - 15 May 2021

I have tested this item successfully on 5992e1b

Code review:

  1. This PR reverts the changes from PR #33893 and does nothing else.
  2. The html elements handled by this PR and the reverted one have the right CSS classes so that the CSS which will be added by PR #33899 will apply to them, too.
    This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33902.
avatar Quy Quy - test_item - 15 May 2021 - Tested successfully
avatar Quy
Quy - comment - 15 May 2021

I have tested this item successfully on 5992e1b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33902.

avatar Quy Quy - change - 15 May 2021
Status Pending Ready to Commit
Labels Added: ?
avatar Quy
Quy - comment - 15 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33902.

avatar chmst chmst - change - 18 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-18 18:39:30
Closed_By chmst
Labels Added: ?
avatar chmst chmst - close - 18 May 2021
avatar chmst chmst - merge - 18 May 2021
avatar brianteeman
brianteeman - comment - 18 May 2021

Thanks

Add a Comment

Login with GitHub to post a comment