Joomla! Issue Tracker | Joomla! CMS #33902 - [4.0] Revert changes in #33893

? ?

Fixed in Code Base
18 May 2021
Medium
Build: 4.0-dev
# 33902
Diff
brianteeman:buttons_revert

Pending

User tests: Successful: Unsuccessful:

brianteeman
15 May 2021

This is the wrong approach and should not have been merged. You dont solve a responsive issue by adding a global class. please see #33899

By using the correct code you do not need to keep adding classes to buttons. Using only #33899 this is fixed correctly

5992e1b 15 May 2021

[4.0] Revert changes in #33717

brianteeman - open - 15 May 2021

brianteeman - change - 15 May 2021

Status

New

⇒

Pending

joomla-cms-bot - change - 15 May 2021

Category

⇒

Administration com_postinstall

richard67 - change - 15 May 2021

Title

…

[4.0] Revert changes in #33~~717~~

[4.0] Revert changes in #33893

richard67 - edited - 15 May 2021

richard67 - comment - 15 May 2021

@brianteeman I was so free to change the title so it refers to the PR to be reverted and not to the issue.

brianteeman - comment - 15 May 2021

oops - thanks - I copy pasted the title

richard67 - test_item - 15 May 2021 - Tested successfully

richard67 - comment - 15 May 2021

I have tested this item ✅ successfully on 5992e1b

Code review:

This PR reverts the changes from PR #33893 and does nothing else.
The html elements handled by this PR and the reverted one have the right CSS classes so that the CSS which will be added by PR #33899 will apply to them, too.
_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33902.}

Quy - test_item - 15 May 2021 - Tested successfully

Quy - comment - 15 May 2021

I have tested this item ✅ successfully on 5992e1b

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33902.}

Quy - change - 15 May 2021

Status	Pending	⇒	Ready to Commit
Labels	Added: ?

Quy - comment - 15 May 2021

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33902.}

chmst - change - 18 May 2021

Status	Ready to Commit	⇒	Fixed in Code Base
Closed_Date	0000-00-00 00:00:00	⇒	2021-05-18 18:39:30
Closed_By		⇒	chmst
Labels	Added: ?

chmst - close - 18 May 2021

chmst - merge - 18 May 2021

brianteeman - comment - 18 May 2021

Thanks

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#33902] - [4.0] Revert changes in #33893

Add a Comment