? ? Pending

User tests: Successful: Unsuccessful:

avatar Kostelano
Kostelano
15 May 2021

Pull Request for Issue #33890.

Testing Instructions

See #33890.

Actual result BEFORE applying this Pull Request

Screenshot_1

Expected result AFTER applying this Pull Request

Screenshot_2

Documentation Changes Required

Not

avatar Kostelano Kostelano - open - 15 May 2021
avatar Kostelano Kostelano - change - 15 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 May 2021
Category Administration com_fields com_menus
avatar brianteeman
brianteeman - comment - 15 May 2021

You do not need to add the fieldset element. Its not a fieldset as its just a single field and a fieldset also requires a legend

avatar brianteeman
brianteeman - comment - 15 May 2021

The problem is caused by the class here

<div id="batch-copy-move" class="control-group radio">

avatar Kostelano
Kostelano - comment - 15 May 2021

Hmm. The problem is that everything is done differently. For example, categories in banners.

Screenshot_1

avatar brianteeman
brianteeman - comment - 15 May 2021

Consistency is terrible. Great that you are spotting these.

Without adding the fieldset but removing the class

<div id="batch-copy-move">
	<?php echo Text::_('JLIB_HTML_BATCH_MOVE_QUESTION'); ?>
	<?php echo HTMLHelper::_('select.radiolist', $options, 'batch[move_copy]', '', 'value', 'text', 'm'); ?>
</div>

image

avatar richard67
richard67 - comment - 15 May 2021

@Kostelano PHP code style check in drone reports mixed line endings for both files. Please make sure you only have Unix line endings.

avatar Kostelano Kostelano - change - 15 May 2021
Labels Added: ?
avatar Kostelano
Kostelano - comment - 15 May 2021

@brianteeman Thanks, I redid it according to your advice.
@richard67 Thanks for the info, I will wait for the result of a new check.

avatar richard67
richard67 - comment - 15 May 2021
avatar brianteeman
brianteeman - comment - 15 May 2021

Looks good - it would be great if you reviewed all the batch modals to make sure that no others have the same problems

avatar RickR2H RickR2H - test_item - 16 May 2021 - Tested successfully
avatar RickR2H
RickR2H - comment - 16 May 2021

I have tested this item successfully on b08f65e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33900.

avatar richard67
richard67 - comment - 16 May 2021

@Kostelano You still haven't fixed the mixed line endings which are reported by the style check in drone and about which I have informed you here 2 times, now the 3rd time. As said, files in our source code have to have Unix line endings, so check and remove all windows line endings.

avatar Kostelano
Kostelano - comment - 17 May 2021

@richard67 I remember, I have not forgotten. I'll fix + see other batch processing modals a bit later.

avatar Quiviro Quiviro - test_item - 4 Jun 2021 - Tested successfully
avatar Quiviro
Quiviro - comment - 4 Jun 2021

I have tested this item successfully on b08f65e

Expected result


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33900.

avatar richard67
richard67 - comment - 4 Jun 2021

@Kostelano It still neds to fix that PHP code style issue with mixed line ending.

avatar Kostelano Kostelano - change - 5 Jun 2021
Labels Added: ?
avatar richard67
richard67 - comment - 5 Jun 2021

@Kostelano PHP code style seems to be fine now. Current drone failure seems not to be related to this PR.

avatar richard67 richard67 - alter_testresult - 5 Jun 2021 - RickR2H: Tested successfully
avatar richard67 richard67 - alter_testresult - 5 Jun 2021 - Quiviro: Tested successfully
avatar richard67
richard67 - comment - 5 Jun 2021

Previous test results are still valid since the commit which invalidated the result was just a code style change. I've restored the results in the issue tracker so they are properly counted.

avatar richard67 richard67 - change - 5 Jun 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 5 Jun 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33900.

avatar drmenzelit drmenzelit - close - 7 Jun 2021
avatar drmenzelit drmenzelit - merge - 7 Jun 2021
avatar drmenzelit drmenzelit - change - 7 Jun 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-06-07 10:14:46
Closed_By drmenzelit
Labels Added: ?
Removed: ?
avatar drmenzelit
drmenzelit - comment - 7 Jun 2021

Thanks

Add a Comment

Login with GitHub to post a comment