? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
15 May 2021

Adds margin-bottom to all buttons only when media-breakpoint-down(sm)

Fix it in one place instead of having to fix every existing button and remembering to fix every future button

image

image

image

avatar brianteeman brianteeman - open - 15 May 2021
avatar brianteeman brianteeman - change - 15 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 May 2021
Category Administration Templates (admin) NPM Change
avatar richard67
richard67 - comment - 15 May 2021

@brianteeman Could you add a "Pull Request for Issue #33717 ." to the description? Thanks in advance.

avatar brianteeman
brianteeman - comment - 15 May 2021

@richard67 its for more than just that PR - its a general issue

avatar richard67
richard67 - comment - 15 May 2021

@brianteeman Yes, but it would help us to reference the issues. To me it looks as if this PR here also replaces #33899 , is that right?

avatar brianteeman
brianteeman - comment - 15 May 2021

Github already did the reference

image

To me it looks as if this PR here also replaces #33899 , is that right?

image

avatar richard67
richard67 - comment - 15 May 2021

@brianteeman Ahh I pasted the wrong number. I meant #33893 . We have #33893 and #33895 open, and both would be obsolete with this one here, which is the better way, I agree with you.

avatar brianteeman
brianteeman - comment - 15 May 2021

@deveshprasad that is unrelated as that field is in the frontend and this PR is for the admin

avatar Quy Quy - test_item - 15 May 2021 - Tested successfully
avatar Quy
Quy - comment - 15 May 2021

I have tested this item successfully on f8bb6bc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33899.

avatar sandramay0905 sandramay0905 - test_item - 16 May 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 16 May 2021

I have tested this item successfully on f8bb6bc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33899.

avatar Quy Quy - change - 16 May 2021
Status Pending Ready to Commit
Labels Added: ?
avatar Quy
Quy - comment - 16 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33899.

avatar richard67 richard67 - change - 18 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-18 18:41:05
Closed_By richard67
Labels Added: ?
avatar richard67 richard67 - close - 18 May 2021
avatar richard67 richard67 - merge - 18 May 2021
avatar richard67
richard67 - comment - 18 May 2021

Thanks!

avatar brianteeman
brianteeman - comment - 18 May 2021

Thank you

Add a Comment

Login with GitHub to post a comment