? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
14 May 2021

PR for #33860

This file is not used anywhere

avatar brianteeman brianteeman - open - 14 May 2021
avatar brianteeman brianteeman - change - 14 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 May 2021
Category Administration com_admin com_fields
avatar PhilETaylor PhilETaylor - test_item - 14 May 2021 - Tested successfully
avatar PhilETaylor
PhilETaylor - comment - 14 May 2021

I have tested this item successfully on f3e9737

Confirm not used.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33864.

avatar Fedik
Fedik - comment - 14 May 2021

@brianteeman please check also admin-field-edit-modal.js file, seems it also can be removed,
and this section:

{
"name": "com_fields.admin-field-edit-modal.es5",
"type": "script",
"uri": "com_fields/admin-field-edit-modal-es5.min.js",
"dependencies": [
"core"
],
"attributes": {
"nomodule": true,
"defer": true
}
},
{
"name": "com_fields.admin-field-edit-modal",
"type": "script",
"uri": "com_fields/admin-field-edit-modal.min.js",
"dependencies": [
"com_fields.admin-field-edit-modal.es5"
],
"attributes": {
"type": "module"
}
},

b42d3ed 14 May 2021 avatar brianteeman js
avatar brianteeman brianteeman - change - 14 May 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 14 May 2021
Category Administration com_admin com_fields Administration com_admin com_fields Repository NPM Change JavaScript
avatar brianteeman
brianteeman - comment - 14 May 2021

@Fedik thanks - good spot. I have updated the pr

avatar Quy Quy - test_item - 18 May 2021 - Tested successfully
avatar Quy
Quy - comment - 18 May 2021

I have tested this item successfully on b42d3ed


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33864.

avatar joomdonation joomdonation - test_item - 15 Jun 2021 - Tested successfully
avatar joomdonation
joomdonation - comment - 15 Jun 2021

I have tested this item successfully on b42d3ed


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33864.

avatar joomdonation joomdonation - change - 15 Jun 2021
Status Pending Ready to Commit
avatar joomdonation
joomdonation - comment - 15 Jun 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33864.

avatar richard67
richard67 - comment - 15 Jun 2021

The file removal in script.php should have been added more below, not in section "// 4.0 from Beta 7 to Beta 8" but in the meanwhile new one "// 4.0 from RC 1 to RC 2", but that's just a formal thing to be consistent with the tool being under development and used used for generating the files and folder lists, and I can fix that later.

avatar richard67 richard67 - change - 15 Jun 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-06-15 10:00:50
Closed_By richard67
Labels Added: ?
avatar richard67 richard67 - close - 15 Jun 2021
avatar richard67 richard67 - merge - 15 Jun 2021
avatar richard67
richard67 - comment - 15 Jun 2021

Thanks!

avatar richard67
richard67 - comment - 15 Jun 2021

See #34521 for the files deletion on update.

avatar brianteeman
brianteeman - comment - 15 Jun 2021

@richard67 at the time the pull request was created the section was correct

avatar richard67
richard67 - comment - 15 Jun 2021

@brianteeman Yes .. sometimes thinks take a while ?

Add a Comment

Login with GitHub to post a comment