User tests: Successful: Unsuccessful:
It is absolutely not necessary to change titles to tooltips. It is a pointless exercise with zero benefits that would need to be done in a gazillion places.
The only time we should be using the black tooltips is as a replacement for the bootstrap tooltips. They are NOT a replacement for titles.
In this specific case the category links now all have the exact same name "edit category" which is obviously an accessibility fail
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_content |
To me it seems so because there were titles before.
Please look at the code, starting tag
in one if
and closing tag
in another if
with the same condition
I don't know, whether this should be there or not
This is clearly a tooltip as its an extended description
As is this
Titles are generally pretty useless https://silktide.com/blog/i-thought-title-text-improved-accessibility-i-was-wrong/ and I personally try to avoid them but there is nothing wrong with having it for something simple and people are used to them.
Replacing all titles with these tooltips "just because" is a pointless exercise - its also a disruption to the content. Titles only appear after a delay. These tooltips appear immediately so you really dont want to have them everywhere.
@rjharishabh no idea what you are talking about
Titles are generally pretty useless https://silktide.com/blog/i-thought-title-text-improved-accessibility-i-was-wrong/ and I personally try to avoid them but there is nothing wrong with having it for something simple and people are used to them.
Replacing all titles with these tooltips "just because" is a pointless exercise - its also a disruption to the content. Titles only appear after a delay. These tooltips appear immediately so you really dont want to have them everywhere.
Got it
@rjharishabh no idea what you are talking about
Line 285 and 289
read the code again
I really have no idea what you are talking about.
see #33839 (comment)
the issue is not accessibility but getting a readable tip. I am not in favor of reverting. On the contrary.
So why have you not insisted that these were tooltips for the last 8 years with Joomla 3? Makes no sense to me other than being contrary
This issue is also about accessibility. It actually breaks accessibility!!
With this PR every links to a category is identified by assistive technology as "Edit Category"
Title |
|
@brianteeman It's still not clear to me if #33748 and #33776 should be reverted, too.
They serve a purpose as its giving an instruction and otherwise we only have an icon
With this PR every links to a category is identified by assistive technology as "Edit Category"
I did not propose that one, but only the Edit articles
#33776 (comment)
@rjharishabh
Sorry if this is totally reverted as I was the one who proposed the tip change.
@infograf768 No problem
I have tested this item
I was amongst those who passed the pr that created this problem. That was on the grounds that having different tip types on adjacent items just looks wrong. I have written something about this to point to when someone comes along next week or next month to do the previous pr again: https://docs.joomla.org/Joomla_4_Tips_and_Tricks:_Titles_and_Tooltips - we can't always rely on @brianteeman's vigilance.
Thanks for writing the document. The examples about what the screen reader will announce is not quite correct as it will depend on several factors such as the screen reader mode, level of verbosity etc. As sighted people its very hard to test for screen readers as there are different levels of expectation about what will be announced AND there is no need to add words such as link or image as they are provided by the screen reader. I would prefer it if the recommendation was to use the tooltip when there is additional information provided only.
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
Labels |
Added:
?
|
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-15 16:29:03 |
Closed_By | ⇒ | Quy | |
Labels |
Added:
?
|
Thank you!
Thanks
@brianteeman Should #33748 and #33776 be reverted, too?