[#33754] - [4.0] Sidebar changes
- Fixed in Code Base
- 13 May 2021
- Medium
- Build: 4.0-dev
- # 33754
- Diff
- dgrammatiko:—handle-sidebar-better—4.0-dev
User tests: Successful: Unsuccessful:
Pull Request for Issue #33660 .
Summary of Changes
- Sidebar now uses cookies instead of locastorage
- The state is echoed also in the index.php
- No more funky animations on the page loads
- Fixes the logo not shrinking according to the sidebar state
Testing Instructions
Check that the menu is maintaining the state as before between page loads. Also check that there's no weird animation on the page load.
Actual result BEFORE applying this Pull Request
Disturbing animation on page loads
Expected result AFTER applying this Pull Request
No animation, page loads with the expected menu state (open/close)
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
@PhilETaylor should be ok with b27ddc5
sorry - This time on Home Dashboard (where the first bug doest happen) toggle switch reverts state - look at the icon
Screen.Recording.2021-05-10.at.10.40.36.pm.mp4
sorry - This time on Home Dashboard (where the first bug doest happen) toggle switch reverts state - look at the icon
Pfff, updating
fixed those two last ones, so here is my final one for you before bed :) Totally unrelated probably :)
The size of the top bar (Brand/Title/Buttons in blue) changes from a list view to an edit view :-)
Screen.Recording.2021-05-10.at.10.46.55.pm.mp4
I have tested this item
Happy as Larry.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33754.
@PhilETaylor thanks, that was quick
@PhilETaylor thanks, that was quick
Great working with devs that know what they are doing :)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33754.
i'll restore the previous test as the change is not code
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33754.
@dgrammatiko I thought I test this PR before I merge it, and I have observed a glitch.
When I reduce browser width so the status of the menu changes from expanded to collapsed, the toggle button doesn't change it's visual status.
Beside that it seems that this PR inverses the display of that status, i.e. collapsed and not collapsed button status look vice versa than before.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Pending |
Back to pending.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33754.
@dgrammatiko Now when reducing the width from desktop to tablet size, the toggle button and the menu toggle status, that's ok.
But when after that enlarging again from tablet to desktop size, only the toggle button changes status but not the menu. As far as I understand, the menu shall not be shown again automatically when enlarging width again, but if that's true, then also the toggle button should not change.
Another thing is that as far as I understand this PR, the menu and the toggle button shall keep their status when reloading the page. But that didn't work here. When the menu was collapsed on small screen, with the reload it was expanded again.
I don't want to exclude the possibility that I did something wrong here. But I've run npm ci after having applied the patch, have cleared browser cache and have deleted the session cookie.
But when after that enlarging again from tablet to desktop size, only the toggle button changes status but not the menu. As far as I understand, the menu shall not be shown again automatically when enlarging width again, but if that's true, then also the toggle button should not change.
The web was not made to be squished as @brianteeman website used to say.
Another thing is that as far as I understand this PR, the menu and the toggle button shall keep their status when reloading the page. But that didn't work here. When the menu was collapsed on small screen, with the reload it was expanded again.
No this is not what this PR addresses. That is a long standing issue with the sidebar and I have other open issues about that and the expectation you have is the same as I had, but others disagreed. I think if I collapse the sidebar manually, it should stay collapsed forever, until I manually expand it again. Others said that was a wrong expectation :-(
But then it is still not right that the toggle button changes it's look while the menu doesn't change when enlarging width again.
Probably, I can't test currently sorry. (Not well)
Probably, I can't test currently sorry. (Not well)
@PhilETaylor Oh, I hope you'll feel better soon.
| Labels |
Removed:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33754.
@sandramay0905 Could you test again? The PR has received some changes. Thanks in advance.
Now these 2 things I have found are fixed, too:
-
When I reduce browser width so the status of the menu changes from expanded to collapsed, the toggle button doesn't change it's visual status.
-
When after that enlarging again from tablet to desktop size, the toggle button changes status, but it shouldn't, because the menu also doesn't expand again (which is desired).
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33754.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33754.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-13 18:58:45 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
|
||
Thank you!!!
@dgrammatiko Can you please confirm this issue on mobile? Thanks.
Joomla logo is expanded pushing the cog icon out of view and toolbar options are displayed by default.
Sorry...
Screen.Recording.2021-05-10.at.10.38.25.pm.mp4