User tests: Successful: Unsuccessful:
Pull Request for Issue #33737
Fixed little mistakes in layout of media component
Go to administrator > media component and switch to list format
You cannot open image preview by double click.
On image preview the close button is far away from the image which looks weird
You are able to open image preview by double click.
The close button is close to the image which I believe looks more beautiful
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_media NPM Change Repository |
@Kostelano It needs to run npm ci after applying the patch.
Sorry, but this does not solve the problem I described. Can you showcase PR work online?
I have tested all proposed changes and they work for me
@eopws Can it be that you referred to the wrong issue in the description? It seems to be something completely different.
Probably the description of my PR is too poor.
In issue #33737 @Kostelano says that by double clicking on image in list format the image gets selected, when it should be opened in preview. Then he says that the image icon should be centered. The pull request is created to fix those problems. Sorry, if something is wrong.
In issue #33737 @Kostelano says that by double clicking on image in list format the image gets selected, when it should be opened in preview. Then he says that the image icon should be centered. The pull request is created to fix those problems. Sorry, if something is wrong.
@eopws I see. I was confused a bit by the screenshot with the red circle around the "X" button. That seems to be a different thing on a first look.
@richard67 @eopws Thanks, it really works now.
About centering the icon - I'm not sure which is better now. It probably makes sense to place the icon not in the center, but at the level of the folder / image header. Like that:
Although, of course, how many people - so many opinions :).
Let's wait for what others have to say.
@richard67 @eopws Thanks, it really works now.
About centering the icon - I'm not sure which is better now. It probably makes sense to place the icon not in the center, but at the level of the folder / image header. Like that:
Although, of course, how many people - so many opinions :).
Let's wait for what others have to say.
It's pretty easy to change. We just have to change the value of vertical-align property.
I see. I was confused a bit by the screenshot with the red circle around the "X" button. That seems to be a different thing on a first look.
I hope it's okay that I didn't make them in different PRs, isn't it?
I hope it's okay that I didn't make them in different PRs, isn't it?
It's ok. I just did not get that it belongs to the issue, too.
I have tested this item
I've ran 'npm ci' after applying the patch
Changed from tile to list view
Double clicked an item and it opens.
The x to close has a better spot now.
Labels |
Added:
NPM Resource Changed
?
|
I have tested this item
Thank you, it works!
I've restored the previous test result in the issue tracker so it's properly counted again, because the commit which invalidated it was just a code style change.
I have tested this item
Close button reasonably place. A bit strange that the whole row is clickable - when the pointer is a finger you expect to click once. I guess that is a separate issue.
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Pending |
The x must be on a separate line to the title
The x must be on a separate line to the title
I think standard practice is to have a modal dialog close button on the same line as the title. I would commit this one because it solves the double click problem. It is really the modal dialog that needs some work to revise the layout.
Filename overlaps close icon.
Can filename have more than 1 line?
Labels |
Added:
?
|
I have tested this item
Real retest, it works.
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-13 20:28:29 |
Closed_By | ⇒ | richard67 | |
Labels |
Added:
?
Removed: ? |
Thanks!
Sorry, but this does not solve the problem I described. Can you showcase PR work online?