NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar eopws
eopws
10 May 2021

Pull Request for Issue #33737

Summary of Changes

Fixed little mistakes in layout of media component

Testing Instructions

Go to administrator > media component and switch to list format

Actual result BEFORE applying this Pull Request

You cannot open image preview by double click.

On image preview the close button is far away from the image which looks weird
before

Expected result AFTER applying this Pull Request

You are able to open image preview by double click.

The close button is close to the image which I believe looks more beautiful
after

avatar eopws eopws - open - 10 May 2021
avatar eopws eopws - change - 10 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 May 2021
Category Administration com_media NPM Change Repository
avatar Kostelano
Kostelano - comment - 10 May 2021

Sorry, but this does not solve the problem I described. Can you showcase PR work online?

avatar richard67
richard67 - comment - 10 May 2021

@Kostelano It needs to run npm ci after applying the patch.

avatar eopws
eopws - comment - 10 May 2021

Sorry, but this does not solve the problem I described. Can you showcase PR work online?

I have tested all proposed changes and they work for me

avatar richard67
richard67 - comment - 10 May 2021

@eopws Can it be that you referred to the wrong issue in the description? It seems to be something completely different.

avatar eopws
eopws - comment - 10 May 2021

@eopws Can it be that you referred to the wrong issue in the description? It seems to be something completely different.

Probably the description of my PR is too poor.
In issue #33737 @Kostelano says that by double clicking on image in list format the image gets selected, when it should be opened in preview. Then he says that the image icon should be centered. The pull request is created to fix those problems. Sorry, if something is wrong.

avatar richard67
richard67 - comment - 10 May 2021

In issue #33737 @Kostelano says that by double clicking on image in list format the image gets selected, when it should be opened in preview. Then he says that the image icon should be centered. The pull request is created to fix those problems. Sorry, if something is wrong.

@eopws I see. I was confused a bit by the screenshot with the red circle around the "X" button. That seems to be a different thing on a first look.

avatar Kostelano
Kostelano - comment - 10 May 2021

@richard67 @eopws Thanks, it really works now.

About centering the icon - I'm not sure which is better now. It probably makes sense to place the icon not in the center, but at the level of the folder / image header. Like that:

Screenshot_1

Although, of course, how many people - so many opinions :).

Let's wait for what others have to say.

avatar eopws
eopws - comment - 10 May 2021

@richard67 @eopws Thanks, it really works now.

About centering the icon - I'm not sure which is better now. It probably makes sense to place the icon not in the center, but at the level of the folder / image header. Like that:

Screenshot_1

Although, of course, how many people - so many opinions :).

Let's wait for what others have to say.

It's pretty easy to change. We just have to change the value of vertical-align property.

avatar eopws
eopws - comment - 10 May 2021

I see. I was confused a bit by the screenshot with the red circle around the "X" button. That seems to be a different thing on a first look.

I hope it's okay that I didn't make them in different PRs, isn't it?

avatar richard67
richard67 - comment - 10 May 2021

I hope it's okay that I didn't make them in different PRs, isn't it?

It's ok. I just did not get that it belongs to the issue, too.

avatar hans2103 hans2103 - test_item - 10 May 2021 - Tested successfully
avatar hans2103
hans2103 - comment - 10 May 2021

I have tested this item successfully on 453863e

I've ran 'npm ci' after applying the patch
Changed from tile to list view
Double clicked an item and it opens.
The x to close has a better spot now.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33753.

avatar hans2103 hans2103 - test_item - 10 May 2021 - Tested successfully
avatar Kostelano
Kostelano - comment - 11 May 2021

@eopws please "pull up" the icons to the same level as the headings and I will mark the PR as successful.

It is, but the inconsistency of the icon-title haunts :). Thank you.

avatar eopws eopws - change - 11 May 2021
Labels Added: NPM Resource Changed ?
avatar eopws
eopws - comment - 11 May 2021

@eopws please "pull up" the icons to the same level as the headings and I will mark the PR as successful.

It is, but the inconsistency of the icon-title haunts :). Thank you.

I'm done. You can check this.

avatar Kostelano Kostelano - test_item - 11 May 2021 - Tested successfully
avatar Kostelano
Kostelano - comment - 11 May 2021

I have tested this item successfully on be97076

Thank you, it works!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33753.

avatar richard67 richard67 - alter_testresult - 11 May 2021 - Kostelano: Tested successfully
avatar richard67
richard67 - comment - 11 May 2021

I've restored the previous test result in the issue tracker so it's properly counted again, because the commit which invalidated it was just a code style change.

avatar ceford ceford - test_item - 11 May 2021 - Tested successfully
avatar ceford
ceford - comment - 11 May 2021

I have tested this item successfully on 91009f3

Close button reasonably place. A bit strange that the whole row is clickable - when the pointer is a finger you expect to click once. I guess that is a separate issue.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33753.

avatar richard67 richard67 - change - 11 May 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 11 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33753.

avatar Quy
Quy - comment - 12 May 2021

Filename overlaps close icon.

33753

avatar Quy Quy - change - 12 May 2021
Status Ready to Commit Pending
avatar brianteeman
brianteeman - comment - 12 May 2021

The x must be on a separate line to the title

avatar ceford
ceford - comment - 13 May 2021

The x must be on a separate line to the title

I think standard practice is to have a modal dialog close button on the same line as the title. I would commit this one because it solves the double click problem. It is really the modal dialog that needs some work to revise the layout.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33753.
avatar eopws
eopws - comment - 13 May 2021

Filename overlaps close icon.

Can filename have more than 1 line?

avatar eopws eopws - change - 13 May 2021
Labels Added: ?
avatar eopws
eopws - comment - 13 May 2021

@Quy

Filename overlaps close icon.

Changed. Please, test new patch.

avatar Kostelano Kostelano - test_item - 13 May 2021 - Tested successfully
avatar Kostelano
Kostelano - comment - 13 May 2021

I have tested this item successfully on 6c926b6

Real retest, it works.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33753.

avatar Quy Quy - test_item - 13 May 2021 - Tested successfully
avatar Quy
Quy - comment - 13 May 2021

I have tested this item successfully on 6c926b6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33753.

avatar Quy Quy - change - 13 May 2021
Status Pending Ready to Commit
avatar Quy
Quy - comment - 13 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33753.

avatar richard67 richard67 - close - 13 May 2021
avatar richard67 richard67 - merge - 13 May 2021
avatar richard67 richard67 - change - 13 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-13 20:28:29
Closed_By richard67
Labels Added: ?
Removed: ?
avatar richard67
richard67 - comment - 13 May 2021

Thanks!

Add a Comment

Login with GitHub to post a comment