User tests: Successful: Unsuccessful:
Pull Request for Issue #33629 .
The links in list earlier were not underlined.
Apply this patch , compile css and have a look on links in dashboard
Links were not underlined
Links are underlined
Status | New | ⇒ | Pending |
Category | ⇒ | Modules Administration |
@himanshu007-creator Sorry, but this PR is wrong. We don't use anywhere the <u>
element to underline links, we use CSS for that.
Furthermore, as you can read here, it shall not be used for underlining links: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/u
Be careful to avoid using the
<u>
element with its default styling (of underlined text) in such a way as to be confused with a hyperlink, which is also underlined by default.
@brianteeman Seems you were a few seconds faster than me ;-)
@richard67 @brianteeman thanks for speedy feedback, really appreciate that!. I get your point. I will try to make changes using CSS only. I will surely work on it tomorrow :)
Labels |
Added:
?
|
@himanshu007-creator this is how I would approach this problem.
My gut feeling is that the styling is already somewhere, and it just needs to modify the CSS selector for it.
@richard67 i am thinking of this
a[class^="flex-grow-1"] {
text-decoration: underline;
}
in file administrator/templates/atum/scss/pages/_com_cpanel.scss
Category | Modules Administration | ⇒ | Administration Templates (admin) NPM Change |
Labels |
Added:
NPM Resource Changed
|
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-11 20:17:38 |
Closed_By | ⇒ | Quy |
Sorry but this is completely wrong. You should be using css here.