NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar himanshu007-creator
himanshu007-creator
10 May 2021

Pull Request for Issue #33629 .

Summary of Changes

The links in list earlier were not underlined.

Testing Instructions

Apply this patch , compile css and have a look on links in dashboard

Actual result BEFORE applying this Pull Request

Links were not underlined

Expected result AFTER applying this Pull Request

Links are underlined

p2

Documentation Changes Required

avatar himanshu007-creator himanshu007-creator - open - 10 May 2021
avatar himanshu007-creator himanshu007-creator - change - 10 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 May 2021
Category Modules Administration
avatar brianteeman
brianteeman - comment - 10 May 2021

Sorry but this is completely wrong. You should be using css here.

avatar richard67
richard67 - comment - 10 May 2021

@himanshu007-creator Sorry, but this PR is wrong. We don't use anywhere the <u> element to underline links, we use CSS for that.

Furthermore, as you can read here, it shall not be used for underlining links: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/u

Be careful to avoid using the <u> element with its default styling (of underlined text) in such a way as to be confused with a hyperlink, which is also underlined by default.

avatar richard67
richard67 - comment - 10 May 2021

@brianteeman Seems you were a few seconds faster than me ;-)

avatar himanshu007-creator
himanshu007-creator - comment - 10 May 2021

@richard67 @brianteeman thanks for speedy feedback, really appreciate that!. I get your point. I will try to make changes using CSS only. I will surely work on it tomorrow :)

avatar himanshu007-creator himanshu007-creator - change - 11 May 2021
Labels Added: ?
avatar himanshu007-creator
himanshu007-creator - comment - 11 May 2021

I have used BS5 text-decoration-underline for this. reference
is it good to go, or do i have to make changes in CSS itself?

avatar himanshu007-creator himanshu007-creator - change - 11 May 2021
The description was changed
avatar himanshu007-creator himanshu007-creator - edited - 11 May 2021
avatar brianteeman
brianteeman - comment - 11 May 2021

@himanshu007-creator this is how I would approach this problem.

  1. Look at the other underlined links and see how they have been styled
  2. Compare the two and then work to apply the same styling
avatar richard67
richard67 - comment - 11 May 2021

My gut feeling is that the styling is already somewhere, and it just needs to modify the CSS selector for it.

avatar himanshu007-creator
himanshu007-creator - comment - 11 May 2021

@richard67 i am thinking of this
a[class^="flex-grow-1"] {
text-decoration: underline;
}

in file administrator/templates/atum/scss/pages/_com_cpanel.scss

avatar joomla-cms-bot joomla-cms-bot - change - 11 May 2021
Category Modules Administration Administration Templates (admin) NPM Change
avatar himanshu007-creator himanshu007-creator - change - 11 May 2021
The description was changed
avatar himanshu007-creator himanshu007-creator - edited - 11 May 2021
avatar himanshu007-creator himanshu007-creator - change - 11 May 2021
Labels Added: NPM Resource Changed
avatar Quy
Quy - comment - 11 May 2021

Closing in favor of PR #33808. Thanks.

avatar Quy Quy - close - 11 May 2021
avatar Quy Quy - change - 11 May 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-05-11 20:17:38
Closed_By Quy

Add a Comment

Login with GitHub to post a comment