[#33749] - [4.0] Improve the cli command discover
- Fixed in Code Base
- 20 May 2021
- Medium
- Build: 4.0-dev
- # 33749
- Diff
- astridx:cli
User tests: Successful: Unsuccessful:
Pull Request for Issue #32967 .
Summary of Changes
I have corrected the misleading duplicate consoles outputs mentioned in #32967 and I have added a task to install and a task to list the detected extensions.
Testing Instructions
Run
php cli/joomla.php extension:discover:list
php cli/joomla.php extension:discover:install
and
php cli/joomla.php extension:discover
The following is an example:
php cli/joomla.php extension:discover:list
! [NOTE] Cannot find discovered extensions. Perhaps you need to run extension:discover first?
php74:/srv/www/joomla/j4dev# php cli/joomla.php extension:discover:install
! [NOTE] There are no discovered extensions for install. Perhaps you need to run extension:discover first?
php74:/srv/www/joomla/j4dev# php cli/joomla.php extension:discover
! [NOTE] 4 extensions have been discovered successfully.
php74:/srv/www/joomla/j4dev# php cli/joomla.php extension:discover:list
Discovered extensions.
======================
------------------------ -------------- --------- ---------- --------
Name Extension ID Version Type Active
------------------------ -------------- --------- ---------- --------
en-GB 306 4.0.0 language No
en-GB 307 4.0.0 language No
en-GB 308 4.0.0 language No
plg_sampledata_testing 309 4.0.0 plugin No
------------------------ -------------- --------- ---------- --------
php74:/srv/www/joomla/j4dev# php cli/joomla.php extension:discover:install --eid 306
[OK] Extension with ID 306 installed successfully.
php74:/srv/www/joomla/j4dev# php cli/joomla.php extension:discover:install
! [NOTE] 3 discovered extensions have been installed.
Actual result BEFORE applying this Pull Request
See #31524
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_installer Libraries Unit Tests |
| Labels |
Added:
?
?
|
||
| Labels |
Added:
?
Removed: ? |
||
I have tested this item
Commands worked as described - discovered and then installed one extension.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33749.
| Labels |
Added:
?
Removed: ? |
||
@PhilETaylor I committed all your suggestions. Please have look, if everything is fine.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33749.
please fix https://ci.joomla.org/joomla/joomla-cms/43524/1/8
funny when we have a pr with unit/system code too
funny when we have a pr with unit/system code too
?
Don't get excited, the unit tests don't actually cover the functionality of the command, which would be very hard to do end-to-end testing on :-) They just test some text strings.
that's another issue
let me be happy to see a pr with system tests ..... whatever
plus a cli pr
| Labels |
Added:
?
Removed: ? |
||
If I were being pedantic I would also remove the word "successfully"...
from
! [NOTE] 4 extensions have been discovered successfully.
They have been "discovered", that is enough to say
! [NOTE] 4 extensions have been discovered.
| Labels |
Added:
?
Removed: ? |
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33749.
@PhilETaylor can you please test this 1
Cough cough #33749 (comment)
@PhilETaylor Well there were commits after your test ... but I've just checked, it was just texts .. so I restore your result in the issue tracker.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33749.
Just texts I meant.
yes it was just tests and the unit tests now pass - that is good enough for me :)
yes it was just tests and the unit tests now pass - that is good enough for me :)
@PhilETaylor Was a typo, not "tests", "texts" I meant. But it's ok.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-20 17:41:39 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
?
Removed: ? |
||
The code works perfectly, and has been tested, just made comments on text strings that can be improved and the file header dates - with those changed, this is ready :)
Thanks!