? Pending

User tests: Successful: Unsuccessful:

avatar srishty-07
srishty-07
10 May 2021

Pull Request for Issue #
Icons are centered

Summary of Changes

Added bootstrap class mx-auto in the PHP file.

Testing Instructions

Go to the dashboard
view the icons.
before the pr, the icons are at the bottom, after this pr the icons are centered in the div

Actual result BEFORE applying this Pull Request

icon1

Expected result AFTER applying this Pull Request

Screenshot (65)

icon

avatar srishty-07 srishty-07 - open - 10 May 2021
avatar srishty-07 srishty-07 - change - 10 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 May 2021
Category Layout
avatar drmenzelit
drmenzelit - comment - 10 May 2021

The alignment of the icons to the left is a design decision, see PR #33100

avatar Fedik
Fedik - comment - 10 May 2021

@srishty-07 It not a bug, it supposed to be left aligned

avatar brianteeman
brianteeman - comment - 10 May 2021

As well as it being a design decision this PR is not correct/complete

image

image

avatar srishty-07
srishty-07 - comment - 11 May 2021

The alignment of the icons to the left is a design decision, see PR #33100

Sorry for the inconvenience, should have checked before sending the pr.

As well as it being a design decision this PR is not correct/complete

image

Thank you @brianteeman for reviewing the pr,
sir, I have only added class to the home page icons, not on the add icon.

avatar rdeutz
rdeutz - comment - 11 May 2021

beause it is a design decision I am closing this

avatar rdeutz rdeutz - close - 11 May 2021
avatar rdeutz rdeutz - change - 11 May 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-05-11 14:09:20
Closed_By rdeutz
Labels Added: ?

Add a Comment

Login with GitHub to post a comment