? ? Pending

User tests: Successful: Unsuccessful:

avatar rjharishabh
rjharishabh
10 May 2021

Pull Request for Issue #.

Summary of Changes

Remove btn-group because of no use here (IMO)
Add div role="tooltip"

Testing Instructions

Dashboard > System > Redirects under Manage

If your site doesn't have any redirects, please create some redirects using New

Actual result BEFORE applying this Pull Request

tooltip-before.mp4

Expected result AFTER applying this Pull Request

tooltip-after.mp4

Documentation Changes Required

No

avatar rjharishabh rjharishabh - open - 10 May 2021
avatar rjharishabh rjharishabh - change - 10 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 May 2021
Category Administration com_redirect
avatar rjharishabh rjharishabh - change - 10 May 2021
Labels Added: ?
avatar Quy
Quy - comment - 10 May 2021

Duplicate id attribute.

33748

avatar rjharishabh
rjharishabh - comment - 10 May 2021

@Quy can I change cb to some other like ed

avatar Quy
Quy - comment - 10 May 2021

Please checkout Banners to see how it is done using aria-labelledby

avatar rjharishabh
rjharishabh - comment - 10 May 2021

Banners use this id="cbunpublish0-desc"

avatar Quy
Quy - comment - 10 May 2021

I’m not at a computer to confirm but yes that should be fine.

avatar chmst
chmst - comment - 10 May 2021

@rjharishabh you also con compare this one: #33557

avatar Quy
Quy - comment - 10 May 2021

Please add aria-labelledby attribute to the a tag.

avatar Quy Quy - test_item - 10 May 2021 - Tested successfully
avatar Quy
Quy - comment - 10 May 2021

I have tested this item āœ… successfully on 246a7af


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33748.

avatar sandramay0905 sandramay0905 - test_item - 11 May 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 11 May 2021

I have tested this item āœ… successfully on 246a7af


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33748.

avatar richard67 richard67 - change - 11 May 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 11 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33748.

avatar chmst chmst - change - 12 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-12 19:48:07
Closed_By chmst
Labels Added: ?
avatar chmst chmst - close - 12 May 2021
avatar chmst chmst - merge - 12 May 2021
avatar chmst
chmst - comment - 12 May 2021

Thanks!

avatar rjharishabh
rjharishabh - comment - 12 May 2021

Thanks

Add a Comment

Login with GitHub to post a comment