[#33718] - [4.0] make Atum error page use template params
- Fixed in Code Base
- 11 May 2021
- Medium
- Build: 4.0-dev
- # 33718
- Diff
- hans2103:feature/error-page-params
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This PR will make it possible to use the Admin template params on an admin error page.
@richard67 thank you for the suggestion how it is implemented in Cassiopeia.
Good or bad... it works.
Testing Instructions
Login Joomla 4 admin
Go to Atum template and change a color.
Logout of Joomla 4 admin
Go to a URL that generates a 403 Forbidden message - here is a quick example:
http://example.com/administrator/index.php?option=com_banners&task=tracks.display&format=raw
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33718.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33718.
I reviewed the code and this would be okay from my end.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-11 07:22:47 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
?
?
|
||
Thanks
This does not fix the same problem for 3d templates.
The params should be already available, for this they should be set by ExceptionHandler::render() where the Document relodaded,
Similar to how it is it done in CMSAplication::render()
I have tested this item✅ successfully on 3edec99
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33718.