?
avatar deveshprasad
deveshprasad
9 May 2021

Intro

My name is Devesh Prasad. I want to contribute to the GSOC 21 project of Joomla that is to add a frontend inline editing feature, after successful installation of code files in the localhost to get familiar with the codebase I have shortlisted some frontend responsive issue which can help me later on with the project of inline editing.
So, I would like to work on these issues.

Responsive issue

1

screen shot 2021-05-09 at 19 06 03

2

screen shot 2021-05-09 at 19 06 03!

3

screen shot 2021-05-09 at 19 06 03!

4

screen shot 2021-05-09 at 19 06 03!

5

screen shot 2021-05-09 at 19 06 03

Expected result

Responsive issues mentioned above to be solved with improved familiarity with the codebase.
By working on the margin and padding and other frontend issues as per the timetable I have mentioned in my GSOC proposal.

Proposal Timeline Mentioned

Proposal link: https://docs.google.com/document/d/1a_Ix_XVIiXLxm1Teu-G5s_BU0DzWtgb5Q43F2VTkVA4/edit?usp=sharing

Name: Devesh Prasad

Email: deveshprasad99911@gmail.com

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
4.00

avatar deveshprasad deveshprasad - open - 9 May 2021
avatar joomla-cms-bot joomla-cms-bot - labeled - 9 May 2021
avatar Bond97
Bond97 - comment - 9 May 2021

I confirmed responsive issue 2, it happens when you use mobile view of Atum template and the resolution is less than the default mobile view in Firefox or Chromium-based browser.

@ciar4n did a great job to repaint Admin UI, but he write, that media manager needs much more work to be fully responsive in mobile view.

avatar deveshprasad
deveshprasad - comment - 11 May 2021

To solve issue 1 above

Which approach should I follow,

  1. By adding bootstrap margins to all the three buttons that is " m-1 " in all the three buttons as adding it on an individual will affect the alignment and gap ratio between all three buttons.
  2. By using media queries in the SCSS file so that when the screen size is a mobile view, the never button should have a top margin.

1

avatar laoneo
laoneo - comment - 11 May 2021

I have also one:
image

avatar deveshprasad
deveshprasad - comment - 14 May 2021

13 05 2021_15 45 42_REC
13 05 2021_20 50 17_REC

One more button margin issue

avatar richard67 richard67 - change - 15 May 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-05-15 08:52:05
Closed_By richard67
avatar richard67
richard67 - comment - 15 May 2021

Closing as having a pull request. See #33895 .

avatar richard67 richard67 - close - 15 May 2021
avatar richard67
richard67 - comment - 15 May 2021

See also #33899 .

avatar laoneo
laoneo - comment - 15 May 2021

Does #33899 solve all issues mentioned here? If not, then I would leave this issue open till everything is resolved.

avatar deveshprasad
deveshprasad - comment - 17 May 2021

To solve this issue:

2
17 05 2021_02 10 20_REC

To solve this issue

We need to go to the:

media->com_media->css->media-manager.css and media-manager.min.css
media->com_media->scss->components->_media-browser.scss

The folder media is mentioned in the gitignore file.

Can someone guide me with the git command lines I should follow to update these files and pushing them ?

avatar richard67
richard67 - comment - 17 May 2021

@deveshprasad The media folder is filled by the build script (some of the js files in the "Build" folder) with what is in the build/media_source folder. The path below that folder stays the same, i.e. build/media_source/com_media belongs to media/com_media. The necessary command to compile the scss or js (the latter is not really compiled but linted and transscripted) you can find here: https://docs.joomla.org/J4.x:Setting_Up_Your_Local_Environment .

Add a Comment

Login with GitHub to post a comment