[#33719] - [4.0] fix position of Joomla button in Atum header
- Fixed in Code Base
- 11 May 2021
- Medium
- Build: 4.0-dev
- # 33719
- Diff
- hans2103:feature/atum-header
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
PR #33654 fixed the placement of Joomla button on the first row.
Caused an unwanted styling bug on com_foo
PR #33689 fixed the styling bug on com_foo
Caused the fix from the first PR
This PR also moves some php blocks to equalize the structure of error_login.php, error_full.php and login.php
Testing Instructions
- Navigate to http://example.com/administrator/index.php?option=com_foo where com_foo is not installed.
- Logout of Joomla 4 admin
- Go to a URL that generates a 403 Forbidden message - here is a quick example:
http://example.com/administrator/index.php?option=com_banners&task=tracks.display&format=raw
Actual result BEFORE applying this Pull Request
administrator/index.php?option=com_foo
administrator/index.php?option=com_banners&task=tracks.display&format=raw
Expected result AFTER applying this Pull Request
administrator/index.php?option=com_foo
administrator/index.php?option=com_banners&task=tracks.display&format=raw
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
I can't find a difference in the screenshots of
administrator/index.php?option=com_foobefore and after pull request.
Because there is no difference in sight... just in HTML.
Actual result BEFORE applying this Pull Request
Note the black text ! Ignore ?
@sandewt The black text should have been fixed with PR #33654 2 days ago.
@richard67 turns out to be true indeed.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33719.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33719.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33719.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-11 07:25:11 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
?
?
|
||
Thanks
I can't find a difference in the screenshots of
administrator/index.php?option=com_foobefore and after pull request.