Feeling Lucky
NPM Resource Changed
?
?
[#33712] - [4.0] Backend - Add style to Privacy Quickicon badge
- Fixed in Code Base
- 12 May 2021
- Medium
- Build: 4.0-dev
- # 33712
- Diff
- YatharthVyas:fix-privacy-badge
User tests: Successful: Unsuccessful:
Pull Request for Issue #33695
Replacement for Closed PRs #33709 and #33711
Summary of Changes
Added a span to display the count. The classes applied to this span are identical to the other quickicon span badges
Testing Instructions
- Run this SQL to give you the same thing:
INSERT INTO `jos_privacy_requests` (`id`, `email`, `requested_at`, `status`, `request_type`, `confirm_token`, `confirm_token_created_at`)
VALUES
(1, 'asdfasd@asdas', '2011-05-09 12:53:18', 0, 'export', '$2y$10$XfdBZSSZMDuhyvHFhJq7e.AUXMtrPOojvcNDEPVWZnOQjKBJfOkum', '2021-05-09 12:53:18'),
(2, 'asdfasd@asdas', '2011-05-09 12:53:18', 1, 'export', '', '2021-05-09 12:53:53'),
(3, 'asdfasd@asdas', '2011-05-09 12:53:18', 1, 'remove', '', '2021-05-09 12:53:58');Alternatively, here's a trick I used:
Change the following line
to :
if (!request.data.number_urgent_requests) {npm run build:js
Note: You might observe a message like below on the admin dashboard:
This is a different issue which has been reported and is not fixed by this PR
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
Quy
- comment
- 11 May 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33712.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 11 May 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33712.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-12 10:11:51 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
|
||
richard67
- comment
- 12 May 2021
Thanks!
YatharthVyas
- comment
- 12 May 2021
Thank you
I have tested this item✅ successfully on d0796d3
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33712.