? ? Pending

User tests: Successful: Unsuccessful:

avatar rjharishabh
rjharishabh
9 May 2021
avatar rjharishabh rjharishabh - open - 9 May 2021
avatar rjharishabh rjharishabh - change - 9 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 May 2021
Category Administration Language & Strings
avatar rjharishabh rjharishabh - change - 9 May 2021
The description was changed
avatar rjharishabh rjharishabh - edited - 9 May 2021
avatar brianteeman
brianteeman - comment - 9 May 2021

Please post a screenshot of this working as I can't see how it would be possible

avatar YatharthVyas YatharthVyas - test_item - 9 May 2021 - Tested unsuccessfully
avatar YatharthVyas
YatharthVyas - comment - 9 May 2021

I have tested this item ? unsuccessfully on df5a43e

Please check the screenshot in my next message:


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33711.

avatar rjharishabh rjharishabh - change - 9 May 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-05-09 17:34:57
Closed_By rjharishabh
Labels Added: ? ?
avatar rjharishabh rjharishabh - close - 9 May 2021
avatar YatharthVyas
YatharthVyas - comment - 9 May 2021

Before

image

After

image

@rjharishabh This is how it looks after applying the patch.

avatar brianteeman
brianteeman - comment - 9 May 2021

to understand what is wrong you need to look at the use of Text::sprintf

avatar rjharishabh rjharishabh - change - 9 May 2021
The description was changed
avatar rjharishabh rjharishabh - edited - 9 May 2021
avatar rjharishabh
rjharishabh - comment - 9 May 2021

@brianteeman sorry it's gone wrong.
I will take care of it from next time

avatar brianteeman
brianteeman - comment - 9 May 2021

its ok - just make sure you check your work before submitting the pr

avatar rjharishabh
rjharishabh - comment - 9 May 2021

its ok - just make sure you check your work before submitting the pr

Yes

Add a Comment

Login with GitHub to post a comment