[#33674] - [4] en-GB verses en-US - order the languages
- Fixed in Code Base
- 9 May 2021
- Medium
- Build: 4.0-dev
- # 33674
- Diff
- PhilETaylor:buildlang
User tests: Successful: Unsuccessful:
Closes #33663
Summary of Changes
I have no idea what any of this means, I just did as I was told by @dgrammatiko haha
Testing Instructions
git checkout 4.0-dev
run the standard jinstall command (as aliased in the docs to be:
alias jclean="rm -rf administrator/templates/atum/css; rm -rf templates/cassiopeia/css; rm -rf administrator/templates/system/css; rm -rf templates/system/css; rm -rf media/; rm -rf node_modules/; rm -rf libraries/vendor/;rm -f administrator/cache/autoload_psr4.php;rm -rf installation/template/css"
alias jinstall="jclean; composer install; npm ci"
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
No changes after running command.
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository |
This did not work :(
This did not work :(
Wrong expectations?
Let me clarify what is happening here. Before #32300 the languages were ordered ascending. After the refactoring the order was random (mostly en-US first and the en-GB but really dependant on the filesystem). Applying this PR the order becomes again asc (en-GB first, en-US second)
ah so you want me to commit these two modified files too? then they will stay like this...
ah so you want me to commit these two modified files too? then they will stay like this...
Yup, that should fix it for everybody and set the ordering to something that is more predictable
| Labels |
Added:
?
|
||
| Category | JavaScript Repository | ⇒ | JavaScript Repository Front End Templates (site) |
Yup, that should fix it for everybody
ok added those files after building them with the new JS
I have tested this item
I was scratching my head over this issue yesterday. Thanks for fixing it!
I tracked the initial files before and after a clean install, they weren't modified.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33674.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33674.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33674.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-09 12:17:33 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
|
||
Thanks all!
I have tested this item✅ successfully on deddb71
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33674.