Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#33673] - [4] add module search filter is persistent

?
avatar PhilETaylor
PhilETaylor
8 May 2021

Steps to reproduce the issue

THINK LIKE A USER NOT A DEVELOPER

Click "add module to the dashboard"
Search for Action
click Action Logs -Latest
(you can't save but thats another issue being dealt with else where) #33630
Close modal
hard refresh the page.
Click "add module to the dashboard"

Expected result

THINK LIKE A USER NOT A DEVELOPER

Search is empty ready to be used again. All available module types are shown.

Actual result

THINK LIKE A USER NOT A DEVELOPER

"As an admin, I have just added the action logs module to the dashboard, and the reason I have clicked "add module to the dashboard" again is to add a different module to the dashboard but first I find I need to delete what I searched for before... which is a pain.. "

Screen.Recording.2021-05-08.at.10.37.40.pm.mp4

System information (as much as possible)

Additional comments

THINK LIKE A USER NOT A DEVELOPER

avatar PhilETaylor PhilETaylor - open - 8 May 2021
avatar joomla-cms-bot joomla-cms-bot - change - 8 May 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 8 May 2021
avatar PhilETaylor PhilETaylor - change - 8 May 2021
The description was changed
avatar PhilETaylor PhilETaylor - edited - 8 May 2021
avatar PhilETaylor PhilETaylor - change - 8 May 2021
The description was changed
avatar PhilETaylor PhilETaylor - edited - 8 May 2021
avatar PhilETaylor PhilETaylor - change - 8 May 2021
Title
…
[4] add module search text is persistent
[4] add module search filter is persistent
avatar PhilETaylor PhilETaylor - edited - 8 May 2021
avatar dgrammatiko
dgrammatiko - comment - 8 May 2021

It seems that this was intended:

joomla-cms/build/media_source/com_modules/js/admin-module-search.es6.js

Lines 98 to 108 in ddc1380

try {
if (typeof (sessionStorage) !== 'undefined') {
// Load the search string from session storage
elSearch.value = sessionStorage.getItem('Joomla.com_modules.new.search') || '';
// Trigger the keyboard handler event manually to initiate the search
elSearch.dispatchEvent(new KeyboardEvent('keyup'));
}
} catch (e) {
// This is probably Internet Explorer which doesn't support the KeyboardEvent constructor :(
}

avatar PhilETaylor
PhilETaylor - comment - 8 May 2021

THINK LIKE A USER NOT A DEVELOPER ;)

I dont think it makes sense with the way it will actually be used.

It was added by @nikosdion in #29463

The search string is stored in the browser's session storage. This means that subsequent opens of the same URL in the same tab and window will remember your search. If you close the tab the saved search string goes away.

doesn't sound like what we really really want here though.

avatar brianteeman
brianteeman - comment - 8 May 2021

Depends on the scenario. If your filter had produced multiple results you would want to return to the same filtered list to try the other modules. its the same with filtering everywhere else. Just seemed particularly odd to you as you had a filter result with just one match

avatar brianteeman
brianteeman - comment - 8 May 2021

For me this is working as intended and desired.

avatar PhilETaylor PhilETaylor - change - 8 May 2021
Status New ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-05-08 22:15:23
Closed_By ⇒ PhilETaylor
avatar PhilETaylor PhilETaylor - close - 8 May 2021
avatar PhilETaylor
PhilETaylor - comment - 8 May 2021

No worries -

Add a Comment

Login with GitHub to post a comment