[#33631] - [4.0] Add module to dashboard - save and close button
- Fixed in Code Base
- 9 May 2021
- Medium
- Build: 4.0-dev
- # 33631
- Diff
- rjharishabh:save-and-close-button
User tests: Successful: Unsuccessful:
Pull Request for Issue #33630 .
Summary of Changes
Testing Instructions
Go to a dashboard, click "add a module".
Select a module, for example, logged-users
A Modal opens for module settings
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_cpanel |
But now we have a save and close too much
@chmst Sorry, but I didn't understand comment
@rjharishabh See the screenshot above. The modal to add new modules has a "Save & Close" button now, but I think it shouldn't.
@rjharishabh See the screenshot above. The modal to add new modules has a "Save & Close" button now, but I think it shouldn't.
means Close and Save should be there, not Save & Close
Only close.
On this screen, we can selct something, but there is nothing to save.
Working on a fix
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-07 17:05:23 |
| Closed_By | ⇒ | rjharishabh | |
| Labels |
Added:
?
|
||
| Status | Closed | ⇒ | New |
| Closed_Date | 2021-05-07 17:05:23 | ⇒ | |
| Closed_By | rjharishabh | ⇒ |
| Status | New | ⇒ | Pending |
| Category | Administration com_cpanel | ⇒ | Administration com_cpanel com_modules |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33631.
@joomdonation code review please
@rjharishabh Look good now. Thanks for working on it. As soon as the codestyle check complete, I will mark my test result and restore @sandramay0905 test result so that it is RTC
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33631.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33631.
Sorry to be late to the party, but close/cancel seems to always be the last (right most) button in other modals and toolbars, can we quickly switch these buttons around please for consistency?
| Status | Ready to Commit | ⇒ | Pending |
Back to pending.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33631.
@rjharishabh I think @PhilETaylor is right and we should change order of these two buttons for consistency. Could you fix that?
Or we can merge this and ask him to make a new PR so that testers don't have to test again. That should work.
merge it!
Or we can merge this and ask him to make a new PR so that testers don't have to test again. That should work.
If this PR needs 2 tests again or if another PR needs 2 tests doesn't make a difference.
For me it's important that it is not forgotten. If I merge this now, I need a new issue for the order.
| Status | Pending | ⇒ | Ready to Commit |
RTC again. @PhilETaylor Please open a new issue for the ordering when this has been merged.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33631.
In trying prove that cancel/close was the last button I found other modals where that was not the case, so there are a few places we need to change (unrelated to this PR)
I thought we had cleaned that up recently.
I thought we had cleaned that up recently.
Me too.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-09 13:21:57 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
|
||
Thanks!
Thanks
Thank you for the fast work - it is good for modules. But now we have a save and close too much