? ? Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
5 May 2021

Pull Request for Issue #33501 .

Summary of Changes

float-left in J3 and float-start in J4 look awkward when the surrounding text contains lists.
Moving the image right is a purely cosmetic operation so the article looks better in blog sample data.

Testing Instructions

Install blog sample data in an installation.

Actual result BEFORE applying this Pull Request

see #33501

Expected result AFTER applying this Pull Request

grafik

Documentation Changes Required

avatar chmst chmst - open - 5 May 2021
avatar chmst chmst - change - 5 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 May 2021
Category Front End Plugins
avatar chmst chmst - change - 5 May 2021
Title
[4.0] Move article image right
[4.0] Blog Sample Data - Move article image right
avatar chmst chmst - edited - 5 May 2021
avatar sandramay0905 sandramay0905 - test_item - 5 May 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 5 May 2021

I have tested this item successfully on fac1d7d

Thanks @chmst for the surprising solution :-)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33559.

avatar YatharthVyas YatharthVyas - test_item - 5 May 2021 - Tested successfully
avatar YatharthVyas
YatharthVyas - comment - 5 May 2021

I have tested this item successfully on fac1d7d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33559.

avatar alikon alikon - change - 5 May 2021
Status Pending Ready to Commit
avatar joomla-cms-bot joomla-cms-bot - edited - 5 May 2021
avatar alikon
alikon - comment - 5 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33559.

avatar brianteeman
brianteeman - comment - 5 May 2021

Sorry this is just masking the problem

avatar brianteeman
brianteeman - comment - 5 May 2021

Moving the image right is a purely cosmetic operation so the article looks better in blog sample data.

This doesn't resolve the actual problem which is that something is wrong when the image is floated left. Not an unreasonable thing for someone to do

avatar YatharthVyas
YatharthVyas - comment - 5 May 2021

overflow

@chmst
A possible way to fix this without moving the image would be by adding:

overflow: hidden;

to the parent <ul> tag

avatar chmst
chmst - comment - 5 May 2021

Cassiopeia in general needs some love. @YatharthVyas make your PR, it will be welcome.

avatar alikon
alikon - comment - 5 May 2021

even if couldn't be the perfect solution... imho it's better than before... moreover it's sample data

avatar brianteeman
brianteeman - comment - 5 May 2021

@alikon you miss the point. The sample data is showing that there is a real problem that all users will face that needs to be resolved correctly.

avatar chmst
chmst - comment - 5 May 2021

Closing as #33560 is the better solution

avatar chmst chmst - change - 5 May 2021
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2021-05-05 19:31:51
Closed_By chmst
Labels Added: ? ?
avatar chmst chmst - close - 5 May 2021
avatar sandramay0905
sandramay0905 - comment - 6 May 2021

Cassiopeia in general needs some love.

@chmst Maybe something like #33463 ;-)?

Add a Comment

Login with GitHub to post a comment