[#33560] - [4.0] Cassiopeia - Add overflow hidden to ul and ol
- Fixed in Code Base
- 5 May 2021
- Medium
- Build: 4.0-dev
- # 33560
- Diff
- YatharthVyas:blog-img-list
User tests: Successful: Unsuccessful:
Pull Request for Issue #33501
Summary of Changes
Added overflow: hidden to <ul> and ol globally.
Lists that are to the right of images having float: left retain their indentations for li, all other lists are not affected by this.
Testing Instructions
Prerequisites: Install blog sample data
- Apply Patch
npm run build:css- Frontend: Visit the blog 'Your Modules' and check the list indentation
- Also, check any blog article that has a list without an image. In this case, everything should remain as is.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings |
| Title |
|
||||||
inline style is not a solution. this must be addressed further up the chain directly in the template
Is https://github.com/joomla/joomla-cms/blob/4.0-dev/templates/cassiopeia/scss/template-rtl.scss the correct file to add
ul,
ol {
overflow: hidden;
}
no. this is for right-to-left - specific things.
These general tags are better defined in /cassiopeia/scss/blocks/_global.scss
| Labels |
Added:
?
?
|
||
| Category | Administration Language & Strings | ⇒ | Front End Templates (site) NPM Change |
| Title |
|
||||||
| Labels |
Added:
NPM Resource Changed
Removed: ? |
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33560.
I have tested this item
Thank you
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33560.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33560.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-05 21:31:05 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
|
||
Thank you!
inline style is not a solution. this must be addressed further up the chain directly in the template