User tests: Successful: Unsuccessful:
Pull Request for Issue #33553 .
Back-integrate from 4.0-dev to here (3.10-dev) the following changes from PR #25761 for fixing bind() with objects in the JTable class:
get_object_vars
if the $src
parameter is an object, so that it is:get_object_vars
.I'm wondering why the 4th step in the above list currently comes before the 1st without this PR.
Step 1: On a current 3.10-dev branch or latest 3.10 nightly build, switch on ""Debug System" and set "Error Reporting" to "Maximum" or "Development".
Step 2: Add the following code to some administrator view:
// Test PR-33558 begin
JTable::addIncludePath(JPATH_ROOT . '/administrator/components/com_contact/tables');
$row1 = JTable::getInstance('Contact', 'ContactTable');
$contact1 = [
'name' => 'Bat Man',
'alias' => 'bat-man',
'catid' => 4,
'params' => ['show_contact_list' => 0, 'show_tags' => ''],
'language' => '*',
'published' => 1,
'access' => 1,
];
$row1->bind($contact1);
$row1->store();
echo '<div>Contact 1 saved.<div>';
$row2 = JTable::getInstance('Contact', 'ContactTable');
$contact2 = new stdClass;
$contact2->name = 'John Doe';
$contact2->alias = 'john-doe';
$contact2->catid = 4;
$contact2->params = ['show_contact_list' => 0, 'show_tags' => ''];
$contact2->language = '*';
$contact2->published = 1;
$contact2->access = 1;
$row2->bind($contact2);
$row2->store();
echo '<div>Contact 2 saved.<div>';
// Test PR-33558 end
E.g. you can add it just before the following line in the users view's default template:
https://github.com/joomla/joomla-cms/blob/3.10-dev/administrator/components/com_users/views/users/tmpl/default.php#L20
The code creates or updates 2 new contact records in database, using bind() and store(), one contact given as array and the other one as object (stdClass).
Step 3: Navigate to the view modified in the previous step.
In my example: "Users -> Manage" (administrator/index.php?option=com_users&view=users
).
Result: Error 'Cannot use object of type stdClass as array', see issue #33553 and section "Actual result BEFORE applying this Pull Request" below.
Step 4: Check in database if the two contacts have been created.
Result: Only the first contact "Bat Man" has been created.
Step 5: Delete that contact.
Step 6: Apply the patch of this PR.
Step 7: Navigate again to the view modified in the previous step, or reload the page if still there.
Result: No error, the debug output is shown, see section "Expected result AFTER applying this Pull Request" below.
Step 8: Check in database if the two contacts have been created.
Result: Both contacts "Bat Man" and "John Doe" have been created.
Storing data fails with error 'Cannot use object of type stdClass as array'.
Storing data succeeds.
The debug output is shown.
None.
Status | New | ⇒ | Pending |
Category | ⇒ | Unit Tests Repository Administration com_admin |
Labels |
Added:
?
?
|
Category | Unit Tests Repository Administration com_admin | ⇒ | Libraries |
Build | staging | ⇒ | 3.10-dev |
Labels |
Removed:
?
|
Category | Libraries | ⇒ | Libraries Unit Tests |
Title |
|
I think keep it as it is. We should see a 3.10 stable in a not so far future.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-07 14:06:08 |
Closed_By | ⇒ | richard67 | |
Labels |
Added:
?
|
@HLeithner As agreed on Glip, I have made this PR here for the 3.10-dev branch. But meanwhile it's clear it fixes a bug only and not introduces any new feature. Shall I rebase it for staging and set the 3.9.27 milestone? Or leave it as it is?