Please change click to select. We don't use click as you can't click on a phone etc

Please use tabs not spaces for indentation

There is a featured button in com_contact as well. No preference on which is better but they should be consistent with each other please

There is a featured button in com_contact as well. No preference on which is better but they should be consistent with each other please

You are right @brianteeman... I've changed it from anchor to button now.

Please review the number of tabs

Please review the number of tabs

damn my settings in PHPStorm.

please recheck the tabs. if you look at the file here on github then you can easily see the multiple errors

please recheck the tabs. if you look at the file here on github then you can easily see the multiple errors

All checks are okay now... according to Drone

I wrote very specifically what you need to do

and I followed the instructions replacing spaces with tabs at the places where Drone complained.

The visually-hidden text can be removed.

https://inclusive-components.design/tooltips-toggletips/#tooltipasprimarylabel
Good catch @chmst

@hans2103 its not just drone that you have to look at. You need to look at the code. Drone only reports on spaces instead of tabs. It doesn't report on too many or too few tabs

Examples

@Quy maybe you can explain better what needs to be done

@brianteeman thank you for the example. I will revert those changes and only commit my intended changes/additions

Those are only examples and not an exhaustive list. It is really obvious what needs correcting when you look at the code here on github

what I have done...

• copied the content from all changed php files from branch 4.0-dev
• reapplied my changes

This should do the trick.

I'm getting crazy... I do see code style changes to parts I did't touch.

You must have automatic code formatting set in your ide

Thought I did.... and followed the steps as explained in PHPStorm.

Seems that my PHPStorm fails like a charm.
Back to vi editor. :-)

Thanks for working on this. Glad to get rid of the Popovers

For further improvements: #33575

@chmst I would create a new issue for this. And yes I agree its a long standing problem that would be good to resolve

@brianteeman Will do - then we can do this in smaller steps.

I have tested this item ✅ successfully on 76b6914

Sorry forgot to record a test

I have tested this item ✅ successfully on 76b6914

Thank you!

I have tested this item ✅ successfully on 76b6914

RTC

Thanks