Feeling Lucky
?
?
[#33516] - [4.0] Remove .text-muted used with .form-text
- Fixed in Code Base
- 4 May 2021
- Medium
- Build: 4.0-dev
- # 33516
- Diff
- Quy:remove-text-muted
- Pending continuous-integration/drone/pr Build is running Details
User tests: Successful: Unsuccessful:
Summary of Changes
In BS5, .form-text no longer sets display, but does set color and font-size. So it is not necessary to include text-muted to adjust color.
Testing Instructions
Apply PR.
Run npm run build:js.
Go to Global Configuration > Server tab.
See description under Force HTTPS.
Go to System > Update > Joomla.
Click Upload & Update tab.
See Maximum upload size: 48.00 MB.
Edit an article.
Click CMS Content > Image.
Select an image.
See description under No Description.
In the other instances, please do code review.
Expected result AFTER applying this Pull Request
Text color is slightly darker which is even better for readability.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate JavaScript Repository NPM Change Installation Layout Front End Plugins |
saumyasarkar11
- comment
- 4 May 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33516.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
Quy
- comment
- 4 May 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33516.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-04 15:53:53 |
| Closed_By | ⇒ | drmenzelit | |
| Labels |
Added:
?
|
||
drmenzelit
- comment
- 4 May 2021
Thanks
I have tested this item✅ successfully on 7e2e34b
Thanks for the PR! Works!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33516.