Feature ? NPM Resource Changed Information Required Maintainers Checked PR-5.0-dev ? ? Pending

User tests: Successful: Unsuccessful:

avatar Shubham-com
Shubham-com
3 May 2021

The two different icons (such as delete and unpublish) have same icons. (i.e, $fa-var-times )

Pull Request for Issue #33432

Summary of Changes

Different icons will perform different works.

Testing Instructions

Actual result BEFORE applying this Pull Request

Screenshot (46)

Expected result AFTER applying this Pull Request

Screenshot (45)

avatar Shubham-com Shubham-com - open - 3 May 2021
avatar Shubham-com Shubham-com - change - 3 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 May 2021
Category Repository NPM Change
avatar brianteeman
brianteeman - comment - 3 May 2021

Be aware that this changes the icon used for unpublished everywhere

avatar Shubham-com
Shubham-com - comment - 3 May 2021

I think that ban symbol can also be used as to unpublish and here,disable icon works similar to unpublish.

avatar RickR2H RickR2H - test_item - 3 May 2021 - Tested successfully
avatar RickR2H
RickR2H - comment - 3 May 2021

I have tested this item successfully on 3fa2c45

I agree that the ban icon is a better option for disabled!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33515.

avatar brianteeman
brianteeman - comment - 3 May 2021

but is it also a good icon for an unpublished article

avatar Quy
Quy - comment - 3 May 2021

How about a - (minus sign) for delete?

avatar drmenzelit
drmenzelit - comment - 4 May 2021

It is not a good icon for unpublished content... it is too "negative", it makes the impression you should not touch the article any more...

avatar Shubham-com
Shubham-com - comment - 4 May 2021

@drmenzelit @brianteeman will it be ok. If changes were made on delete icon and rest of the things are remain unchanged. Something like this....
Screenshot (48)

Don't know whether I am correct or not..I think it can be soved using two ways:-

i) change the delete icon to trash and rest of things remain unchanged
ii) create a new icon for disable one.

avatar drmenzelit
drmenzelit - comment - 4 May 2021

I'm talking about the unpublished icon here for example:
grafik
And about trash icon for delete, please read the comment here: #33432 (comment)

avatar drmenzelit
drmenzelit - comment - 4 May 2021

My suggestion was to create an own icon class for disable

avatar chmst
chmst - comment - 6 May 2021

How about using the disc / circle / not default for disabled everywhere? "x" looks alwys like "forbidden"

avatar ceford
ceford - comment - 9 May 2021

You could use thumbs-up/thumbs-down for enable/disable. I don't think the trash can is appropriate for delete because items in trash can be recovered but items deleted are not.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33515.

avatar brianteeman
brianteeman - comment - 9 May 2021

thanks to facebook and youtube thumbsup/down means like/dislike to most people

avatar Shubham-com
Shubham-com - comment - 9 May 2021

In general, thumbs-up/thumbs-down shows that you are agree or approval and vice-versa with something,

avatar ceford
ceford - comment - 9 May 2021

toggle-on/toggle-off might work for enable/disable (but I quite like thumbs).

avatar hans2103
hans2103 - comment - 10 May 2021

@chmst How about using the disc / circle / not default for disabled everywhere? "x" looks alwys like "forbidden"

If you do this, the publish icon in the dropdown should be changed to a circle with a checkmark too.

@Shubham-com i) change the delete icon to trash and rest of things remain unchanged

I like this proposal. Change the x, currently used for delete, by a trashcan

update... copied text from external chat

The problem is that trash in Joomla doesn't mean delete, something get in the trash bin and you have to empty it... delete is really delete, gone for ever... we need a new icon for it or for disable

Delete icons by FontAwesome => https://fontawesome.com/icons?d=gallery&p=2&q=delete&m=free
Disable icons by FontAwesome => https://fontawesome.com/icons?d=gallery&p=2&q=disable&m=free <- not really useful I think

avatar Shubham-com
Shubham-com - comment - 11 May 2021

I agreed what the @hans2103 said, no better icon found
we can use trash icon
Screenshot (51)
for those items can be recovered,which is already being used for trash.
Screenshot (50)

and trash-alt icon for delete which can be used for delete forever,and it can some how differ between them.

avatar Shubham-com
Shubham-com - comment - 11 May 2021

The same issue with Extension: Manage
Go to System> Manage Extension

Both Disable and Uninstall have same (X) icon.
Screenshot (53)

avatar Quy
Quy - comment - 11 May 2021

Please don't use the different trash cans. I won't remember the purpose of each one.

Use the minus sign like in a shopping cart ... + to add an item and - to remove an item from the cart.

avatar hans2103
hans2103 - comment - 11 May 2021

summary.
(correct me if I'm wrong)

We need (new) icons for the following purposes

  • disable / unpublish
  • uninstall
  • move-to-trash

my suggestions

avatar brianteeman
brianteeman - comment - 11 May 2021

I am just seeing a need for an icon for delete and an icon for uninstall

As delete and uninstall are both permanent action that can not be undone I would suggest something like https://fontawesome.com/icons/exclamation-triangle?style=solid

avatar Shubham-com
Shubham-com - comment - 12 May 2021

Thanks everyone for your suggestion, Please don't mind it.. but I still suggest trash can for delete and
uninstall purposes as many of you have also seen this icon(i.e., trash can) before while uninstalling and deleting
any apps or software from your device.

And for move-to trash, means that the items that can be recovered..I suggest the Recycle icon
(https://fontawesome.com/icons/recycle?style=solid) the arrows in the recycle icon also indicates that
them items which are moved in trash can get recovered.

avatar sandramay0905 sandramay0905 - test_item - 14 May 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 14 May 2021

I have tested this item successfully on 3fa2c45


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33515.

avatar richard67
richard67 - comment - 14 May 2021

@sandramay0905 This PR has the "Updates Requested" label set, which means some reviewer requested changes, and since that label has been set, no change has been made, so it doesn't make much sense to test that PR now. It will not get RTC even with 2 tests as long as that review has not been clarified.

@Quy Could you check if your request is still valid?

avatar Shubham-com
Shubham-com - comment - 14 May 2021

Please also update me, what changes would you want . I got too much confused, as different suggestions from different reviewers.

avatar sandramay0905
sandramay0905 - comment - 14 May 2021

This PR has the "Updates Requested" label set, which means some reviewer requested changes, and since that label has been set, no change has been made, so it doesn't make much sense to test that PR now.

Thanks for the info, @richard67, haven't know that. I'm not sure if i noticed that label in the future, grayscale is not so easy to see :-)

avatar Shubham-com Shubham-com - change - 15 May 2021
Labels Added: NPM Resource Changed ? ?
avatar drmenzelit
drmenzelit - comment - 29 Dec 2021

Can we reach a consensus on this one? @Shubham-com @brianteeman @hans2103

avatar chmst chmst - change - 31 Jan 2022
Labels Added: ? ? Information Required ?
Removed: ? ?
avatar HLeithner
HLeithner - comment - 27 Jun 2022

This pull request has automatically rebased to 4.2-dev.

avatar joomla-bot
joomla-bot - comment - 27 Jun 2022

This pull requests has been automatically converted to the PSR-12 coding standard.

avatar Hackwar Hackwar - change - 1 Mar 2023
Labels Added: Maintainers Checked PR-4.3-dev ? ?
Removed: ? ?
avatar HLeithner
HLeithner - comment - 2 May 2023

This pull request has been automatically rebased to 5.0-dev.

avatar HLeithner HLeithner - change - 31 Aug 2023
Labels Added: Feature PR-5.0-dev
Removed: PR-4.3-dev
avatar ceford ceford - test_item - 9 Sep 2023 - Tested unsuccessfully
avatar ceford
ceford - comment - 9 Sep 2023

I have tested this item ? unsuccessfully on 2182d87

Is this Issue abandoned? I tested it and it does not work - seems only relevant for backward compatibility.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33515.

avatar HLeithner
HLeithner - comment - 30 Sep 2023

This pull request has been automatically rebased to 5.1-dev.

avatar drmenzelit
drmenzelit - comment - 30 Oct 2023

Closing this in favour of #42250

avatar drmenzelit drmenzelit - change - 30 Oct 2023
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2023-10-30 10:35:19
Closed_By drmenzelit
Labels Added: ? ? ?
Removed: ? ? ?
avatar drmenzelit drmenzelit - close - 30 Oct 2023

Add a Comment

Login with GitHub to post a comment