? ? Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
2 May 2021

Pull Request for Issue # .

Summary of Changes

Improve UX. Users can select a number of columns from a dropdown. (was a text input field).

Testing Instructions

Compare menu items for blog and featured before and after Patch.

Actual result BEFORE applying this Pull Request

grafik

Expected result AFTER applying this Pull Request

grafik

Documentation Changes Required

avatar chmst chmst - open - 2 May 2021
avatar chmst chmst - change - 2 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 May 2021
Category Front End com_content
avatar chmst
chmst - comment - 2 May 2021

Thanks for the nudge @angieradtke

avatar brianteeman
brianteeman - comment - 2 May 2021

Not sure about this being a dropdown as it enforces a maximum number of columns. Why not just correct the type of the field from text to number.

avatar sandramay0905 sandramay0905 - test_item - 2 May 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 2 May 2021

I have tested this item successfully on 259aaae


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33482.

avatar chmst
chmst - comment - 2 May 2021

@brianteeman The css is made for 4 columns maximum.

avatar brianteeman
brianteeman - comment - 2 May 2021

for cassiopeia but what about a custom template?

avatar chmst
chmst - comment - 2 May 2021

Touchée. Will commit asap.

avatar ChristineWk ChristineWk - test_item - 2 May 2021 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 2 May 2021

I have tested this item successfully on 259aaae

I think, 4 columns are enough :-)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33482.

avatar brianteeman
brianteeman - comment - 2 May 2021

I think, 4 columns are enough :-)

Really depends on the use case.

avatar angieradtke
angieradtke - comment - 2 May 2021

@chmst welcome -> I am just talking and you have the work

@brianteeman @ChristineWk
4 columns are enough-> if we can be flexible here, it would be great. If not we have to deal width 4

maybe an example : If we want to build a horizontal snapslider it would be great to select 10 columns

avatar chmst chmst - change - 2 May 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 2 May 2021
Category Front End com_content Administration com_content Front End
avatar chmst
chmst - comment - 2 May 2021

Thank you all. I have changed the dropdowns to number field.

avatar ChristineWk
ChristineWk - comment - 2 May 2021

I think, 4 columns are enough :-)

Really depends on the use case.

yes of course :-)

avatar ChristineWk
ChristineWk - comment - 2 May 2021

you are too fast :-) following just for info:

avatar ChristineWk
ChristineWk - comment - 2 May 2021

4 columns not possible if there are modules on the right position :-)
screen shot 2021-05-02 at 11 14 11


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33482.

avatar ChristineWk
ChristineWk - comment - 2 May 2021

@chmst

amendments to number fields works now, but a question:
screen shot 2021-05-02 at 11 16 33
The arrows are inactive?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33482.

avatar angieradtke
angieradtke - comment - 2 May 2021

4 columns not possible if there are modules on the right position :-)

depends on the template .-)

avatar brianteeman brianteeman - test_item - 2 May 2021 - Tested successfully
avatar brianteeman
brianteeman - comment - 2 May 2021

I have tested this item successfully on f75a189


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33482.

avatar sandramay0905
sandramay0905 - comment - 2 May 2021

The arrows are inactive?

@ChristineWk i think they show that its a number field, arrow-up -down works. But first i tried to click with the mouse :-)

avatar ChristineWk ChristineWk - test_item - 2 May 2021 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 2 May 2021

I have tested this item successfully on f75a189


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33482.

avatar ChristineWk
ChristineWk - comment - 2 May 2021

4 columns not possible if there are modules on the right position :-)

depends on the template .-)

of course :-) @angieradtke

avatar sandramay0905 sandramay0905 - test_item - 2 May 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 2 May 2021

I have tested this item successfully on f75a189


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33482.

avatar richard67 richard67 - change - 2 May 2021
Title
[4.0] [UX] Use dropdown list for num_columns in blog and featured layout
[4.0] [UX] Use number field for num_columns in blog and featured layout
avatar richard67 richard67 - edited - 2 May 2021
avatar richard67
richard67 - comment - 2 May 2021

I've allowed myself to change the title of this PR so it fits to latest changes for using number fields.

avatar richard67 richard67 - change - 2 May 2021
Status Pending Ready to Commit
avatar richard67 richard67 - edited - 2 May 2021
avatar richard67
richard67 - comment - 2 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33482.

avatar richard67
richard67 - comment - 2 May 2021

Drone failure is not related to this PR, see issue #33477 .

avatar richard67 richard67 - change - 2 May 2021
Labels Added: ?
avatar richard67 richard67 - alter_testresult - 2 May 2021 - ChristineWk: Tested successfully
avatar richard67 richard67 - alter_testresult - 2 May 2021 - sandramay0905: Tested successfully
avatar richard67
richard67 - comment - 2 May 2021

I've updated the branch to latest 4.0-dev to get rid of the unrelated javascript-cs error in drone and restored the previous test results in the issue tracker.

avatar drmenzelit drmenzelit - change - 2 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-02 19:52:07
Closed_By drmenzelit
Labels Added: ?
Removed: ?
avatar drmenzelit drmenzelit - close - 2 May 2021
avatar drmenzelit drmenzelit - merge - 2 May 2021
avatar drmenzelit
drmenzelit - comment - 2 May 2021

Thanks

Add a Comment

Login with GitHub to post a comment