NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar sksuryan
sksuryan
2 May 2021

Pull Request for Issue #33443 .

Summary of Changes

This Pull Request modifies administrator/templates/atum/scss/vendor/bootstrap/_dropdown.scss.
The issue was that if the dropdown menu contains only a single button, then there would be not border radius for the button. This was caused because if a dropdown menu contained only a single button, it would have both the classes first as well as last, hence overriding the border-radius property that has been set in template-rtl.scss and removing border radius from bottom and top respectively.

In this pull request a check has been added to see if the element contains both first and last classes, if it does then the style won't be applied.

Testing Instructions

  • Login to Administrator
  • Go to Menus > Manage > New
  • Expand the Save & Close dropdown menu and hover over Save & New.
  • Check if Save & New has the border radius for all 4 corners.

Check if other dropdown menus are fine ( Before & After results will be same for this one).

  • Go to Menus > All Menu Items.
  • Click on one of the items that are listed, for eg: Home.
  • Expand the Save & Close dropdown menu and hover over Save & New and Save as Copy.
  • Check if Save & New has the border radius for top corners and Save as Copy has border radius for bottom corners.

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Documentation Changes Required

Nope.

avatar sksuryan sksuryan - open - 2 May 2021
avatar sksuryan sksuryan - change - 2 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 May 2021
Category Administration Templates (admin) NPM Change
avatar richard67 richard67 - change - 2 May 2021
Labels Added: NPM Resource Changed ?
avatar richard67
richard67 - comment - 2 May 2021

I've updated the branch to latest 4.0-dev to get rid of the unrelated javascript-cs error in drone.

avatar Kostelano Kostelano - test_item - 3 May 2021 - Tested successfully
avatar Kostelano
Kostelano - comment - 3 May 2021

I have tested this item successfully on 3648acc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33483.

avatar sandramay0905 sandramay0905 - test_item - 3 May 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 3 May 2021

I have tested this item successfully on 3648acc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33483.

avatar richard67 richard67 - change - 3 May 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 3 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33483.

avatar chmst chmst - close - 3 May 2021
avatar chmst chmst - merge - 3 May 2021
avatar chmst chmst - change - 3 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-03 08:15:06
Closed_By chmst
Labels Added: ?
avatar chmst
chmst - comment - 3 May 2021

Thanks!

Add a Comment

Login with GitHub to post a comment