[#33473] - [4.0] Fix tabs in User Access levels and Joomla Update Complete View
- Fixed in Code Base
- 2 May 2021
- Medium
- Build: 4.0-dev
- # 33473
- Diff
- YatharthVyas:fix-user-tab-style
User tests: Successful: Unsuccessful:
Pull Request for Issue #33440
Summary of Changes
- Added Tabs to User Access Level View
- Added tabs to Joomla Update Complete View and removed that fieldset and legend tag that enclosed the alert box.
Testing Instructions
For User Access Levels
- Joomla Admin Panel -> Users
- Select Access Levels
- Click on New
For Joomla Update Complete View
Visit /administrator/index.php?option=com_joomlaupdate&view=joomlaupdate&layout=complete
Verify that tabs are present on both of these views
Actual result BEFORE applying this Pull Request
For User Access Levels
For Joomla Update Complete View
Expected result AFTER applying this Pull Request
For User Access Levels
Fieldsets and Legends are separated tab wise to keep the view consistent with other user forms like the ones in Manage Users
For Joomla Update Complete View
Removed Fieldset that enclosed the alert-box and added a tab as requested in the issue.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate com_users |
can you have "tabs" if you only have one "tab"? seems strange to me.
I agree.
At the same time, some views have a tab for a single form (eg: User Groups). On grounds of that, it was requested by the issue's author to repeat the same here for consistency. However, if you feel this isn't correct, please let me know if I should implement it in a different way.
I dont have any strong feelings either way - I know in my own projects I have done a single tab too for "visual reasons", but I think the concept is flawed :)
I have tested this item
Looks better so :-)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33473.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33473.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33473.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-02 19:20:47 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
?
|
||
Thanks!
can you have "tabs" if you only have one "tab"? seems strange to me.