[#33472] - [4] Introducing empty state to modules
- Fixed in Code Base
- 4 May 2021
- Medium
- Build: 4.0-dev
- # 33472
- Diff
- PhilETaylor:emptystate/modules
User tests: Successful: Unsuccessful:
Summary of Changes
Introducing empty state design for modules. A lot less complex than the component versions.
This first PoC on the 3 modules shown by default on the home page of the Joomla 4 admin after first login. Those are
mod_latest
mod_popular
mod_privacy_dashboard
The sentence displayed can reuse existing empty state title from the component, or a new one can be overloaded for modules in the language strings
Can handle more than one module type per component with the use of textSuffix
Testing Instructions
Load Joomla 4 admin console.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Modules Layout |
| Labels |
Added:
?
?
|
||
"No Information Requests have been submitted yet." is the current language value from the component. So if you dont like it here, you are going to hate it there too.
And the two articles strings are NOT trying to say that there are no articles in the database, they are trying to say that the purpose of the module is a empty state, and as the data for these modules is about Popular and Recently added articles, the language has to reflect that underlying dataset - there are no popular articles and there are no recent articles. You could well have 1000 articles, but without 1 visitors the popular module could still be empty of data.
While that may actually be true - Silly Joomla goes and puts articles with Zero hits in the module.. /facepalm
| Category | Administration Language & Strings Modules Layout | ⇒ | Modules Administration Layout |
I have removed the module override language strings for the empty state to allow them to inherit from the components empty state language tites.
| Labels |
Removed:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33472.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33472.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33472.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-04 18:46:40 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
Removed: ? |
||
Thank you!
The strings are not correct.
No current privacy requests
There are no articles