? ? ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
1 May 2021

Summary of Changes

Empty State for com_installer - the Updates page.

DEPENDS ON AND REQUIRES THE CHANGES IN #33471 AS WELL

Testing Instructions

Apply Pr. Click buttons.

Actual result BEFORE applying this Pull Request

Screenshot 2021-05-01 at 20 43 00

Expected result AFTER applying this Pull Request

Screenshot 2021-05-01 at 20 42 05

Documentation Changes Required

screenshots

avatar PhilETaylor PhilETaylor - open - 1 May 2021
avatar PhilETaylor PhilETaylor - change - 1 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 May 2021
Category Administration com_categories com_installer
avatar PhilETaylor PhilETaylor - change - 1 May 2021
Labels Added: ?
28123fc 1 May 2021 avatar PhilETaylor doh
avatar joomla-cms-bot joomla-cms-bot - change - 1 May 2021
Category Administration com_categories com_installer Administration com_installer
avatar sandramay0905 sandramay0905 - test_item - 2 May 2021 - Tested unsuccessfully
avatar sandramay0905
sandramay0905 - comment - 2 May 2021

I have tested this item 🔴 unsuccessfully on cb2fd3d

After applying #33747 & #33471 using patchtester got:

image


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33474.
avatar joomla-cms-bot joomla-cms-bot - change - 2 May 2021
Category Administration com_installer Administration com_installer Language & Strings
avatar PhilETaylor
PhilETaylor - comment - 2 May 2021

Correct, looks like the language file was not added to the right branch for some reason - I have added it now. Thanks for testing.

avatar ChristineWk
ChristineWk - comment - 2 May 2021

Had the same result before, as @sandramay0905. Now, with added language file, it's OK.
Checked with both Patches applied.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33474.

avatar ChristineWk ChristineWk - test_item - 2 May 2021 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 2 May 2021

I have tested this item ✅ successfully on 080aa46


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33474.

avatar PhilETaylor
PhilETaylor - comment - 2 May 2021

Had the same result before, as @sandramay. Now, with added language file, it's OK.

Sorry for wasting your time before, I was working on 2 different development workstations in 2 locations and 4 branches at the same time and I missed adding this language to the right branch. Sorry.

avatar ChristineWk
ChristineWk - comment - 2 May 2021

It's OK, take a sip of coffee in between :-)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33474.

avatar sandewt sandewt - test_item - 2 May 2021 - Tested successfully
avatar sandewt
sandewt - comment - 2 May 2021

I have tested this item ✅ successfully on 080aa46


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33474.

avatar richard67 richard67 - change - 2 May 2021
The description was changed
Status Pending Ready to Commit
avatar richard67 richard67 - edited - 2 May 2021
avatar richard67
richard67 - comment - 2 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33474.

avatar richard67
richard67 - comment - 2 May 2021

Drone failure is not related to this PR, see issue #33477 .

avatar richard67 richard67 - change - 2 May 2021
Labels Added: ? ?
avatar richard67 richard67 - alter_testresult - 2 May 2021 - ChristineWk: Tested successfully
avatar richard67 richard67 - alter_testresult - 2 May 2021 - sandewt: Tested successfully
avatar richard67
richard67 - comment - 2 May 2021

I've updated the branch to latest 4.0-dev to get rid of the unrelated javascript-cs error in drone and restored the previous test results in the issue tracker.

avatar PhilETaylor
PhilETaylor - comment - 2 May 2021

drone failed again unrelated with something to do with media manager..

avatar wilsonge wilsonge - change - 2 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-02 22:10:23
Closed_By wilsonge
Labels Added: ?
Removed: ?
avatar wilsonge wilsonge - close - 2 May 2021
avatar wilsonge wilsonge - merge - 2 May 2021
avatar wilsonge
wilsonge - comment - 2 May 2021

Thanks!

Add a Comment

Login with GitHub to post a comment