? ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
26 Apr 2021

Pull Request for Issue #33328 Replacement for #33332

Summary of Changes

Adding the icon to the $displayData. The icon will default to the article one if none is given.
Restoring the original icons for the various blankstate layouts (eg contacts, newsfeeds, banners, user notes, ...)

Testing Instructions

Check the various views when no item is created yet and see what icon is used in the blankstate layout.

Actual result BEFORE applying this Pull Request

Always the same icon (copy) is used

Expected result AFTER applying this Pull Request

The views have different icons matching the context.

Documentation Changes Required

None

avatar PhilETaylor PhilETaylor - open - 26 Apr 2021
avatar PhilETaylor PhilETaylor - change - 26 Apr 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Apr 2021
Category Administration com_banners com_contact com_content com_messages com_newsfeeds com_users Layout
avatar brianteeman brianteeman - test_item - 26 Apr 2021 - Tested successfully
avatar brianteeman
brianteeman - comment - 26 Apr 2021

I have tested this item successfully on 98876c8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33333.

avatar brianteeman
brianteeman - comment - 26 Apr 2021

I have tested this item successfully on 98876c8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33333.

avatar alikon alikon - test_item - 26 Apr 2021 - Tested successfully
avatar alikon
alikon - comment - 26 Apr 2021

I have tested this item successfully on 98876c8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33333.

avatar alikon alikon - change - 26 Apr 2021
Status Pending Ready to Commit
avatar alikon
alikon - comment - 26 Apr 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33333.

avatar Quy Quy - close - 26 Apr 2021
avatar Quy Quy - merge - 26 Apr 2021
avatar Quy Quy - change - 26 Apr 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-04-26 13:05:20
Closed_By Quy
Labels Added: ? ?
avatar Quy
Quy - comment - 26 Apr 2021

Thanks

Add a Comment

Login with GitHub to post a comment