? Pending

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
26 Apr 2021

Pull Request for Issue #33328

Summary of Changes

Adding the icon to the $displayData. The icon will default to the article one if none is given.
Restoring the original icons for the various blankstate layouts (eg contacts, newsfeeds, banners, user notes, ...)

Testing Instructions

Check the various views when no item is created yet and see what icon is used in the blankstate layout.

Actual result BEFORE applying this Pull Request

Always the same icon (copy) is used

Expected result AFTER applying this Pull Request

The views have different icons matching the context.

Documentation Changes Required

None

avatar Bakual Bakual - change - 26 Apr 2021
Status New Pending
avatar Bakual Bakual - open - 26 Apr 2021
avatar joomla-cms-bot joomla-cms-bot - change - 26 Apr 2021
Category Administration com_banners com_contact com_content com_messages com_newsfeeds com_users Layout
avatar PhilETaylor
PhilETaylor - comment - 26 Apr 2021

you need to rebase this on 4.0-dev to avoid the conflicts :)

avatar PhilETaylor
PhilETaylor - comment - 26 Apr 2021

I have fixed the conflicts for you - please close this one and test #33333

avatar richard67
richard67 - comment - 26 Apr 2021

Closing in favour of #33333 , see previous comments.

avatar richard67 richard67 - change - 26 Apr 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-04-26 07:58:31
Closed_By richard67
Labels Added: ?
avatar richard67 richard67 - close - 26 Apr 2021

Add a Comment

Login with GitHub to post a comment