? ? Pending

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
26 Apr 2021

Pull Request for Issue #33319 .

Summary of Changes

Don't show the create button when the blankstate layout is loaded in a modal. Eg when using the "Select" button in a single article menuitem.
In modals, we also don't show the toolbar buttons, so this makes most sense to me.

Testing Instructions

Brian did a good video to show the issue in #33319

Actual result BEFORE applying this Pull Request

Create button is shown in modal

Expected result AFTER applying this Pull Request

Create button is not shown in modal

Documentation Changes Required

None

avatar Bakual Bakual - open - 26 Apr 2021
avatar Bakual Bakual - change - 26 Apr 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Apr 2021
Category Layout
avatar brianteeman brianteeman - test_item - 26 Apr 2021 - Tested successfully
avatar brianteeman
brianteeman - comment - 26 Apr 2021

I have tested this item successfully on 974780c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33331.

avatar alikon alikon - test_item - 26 Apr 2021 - Tested successfully
avatar alikon
alikon - comment - 26 Apr 2021

I have tested this item successfully on 974780c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33331.

avatar alikon alikon - change - 26 Apr 2021
Status Pending Ready to Commit
avatar alikon
alikon - comment - 26 Apr 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33331.

avatar Quy Quy - change - 26 Apr 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-04-26 13:06:47
Closed_By Quy
Labels Added: ? ?
avatar Quy Quy - close - 26 Apr 2021
avatar Quy Quy - merge - 26 Apr 2021
avatar Quy
Quy - comment - 26 Apr 2021

Thanks

Add a Comment

Login with GitHub to post a comment