[#33334] - [4] Rename recent BlankState feature to EmptyState
- Fixed in Code Base
- 27 Apr 2021
- Medium
- Build: 4.0-dev
- # 33334
- Diff
- PhilETaylor:renameblankstate
User tests: Successful: Unsuccessful:
The concept we are implementing is called Empty State design, therefore it makes sense to use that term throughout and not to confuse people with "Blank state/Blank slate" terms. Sorry, that was my fault.
Therefore at this early stage it makes sense to get our own house in order from the start and use the term "Empty State" to refer to the "Empty State Design UX" we are employing.
References (just a quick google):
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners com_contact com_content com_messages com_newsfeeds com_users Layout |
yeah I probably should do that too. Thanks.
Please rename the language constants too.
| Labels |
Added:
?
|
||
| Category | Administration com_banners com_contact com_content com_messages com_newsfeeds com_users Layout | ⇒ | Administration com_banners com_contact com_content com_messages com_newsfeeds com_users Layout Libraries |
| Category | Administration com_banners com_contact com_content com_messages com_newsfeeds com_users Layout Libraries | ⇒ | Administration com_banners com_contact com_content com_messages com_newsfeeds com_users Language & Strings Layout Libraries |
Please rename the language constants too.
Done.
Will the IsBlankSlate be renamed, too?
Done.
| Labels |
Added:
?
|
||
Conflicting files
administrator/components/com_banners/tmpl/banners/blankstate.php
administrator/components/com_contact/tmpl/contacts/blankstate.php
administrator/components/com_content/tmpl/articles/blankstate.php
administrator/components/com_messages/tmpl/messages/blankstate.php
administrator/components/com_newsfeeds/tmpl/newsfeeds/blankstate.php
administrator/components/com_privacy/tmpl/consents/blankstate.php
administrator/components/com_privacy/tmpl/requests/blankstate.php
administrator/components/com_users/tmpl/notes/blankstate.php
layouts/joomla/content/blankstate.php
grrrr ill take a look tonight
Rebased on 4.0-dev to fix conflicts and force pushed.
feeling guilty...
but this task cannot be automated ? (unit/system) test
GitHub said it was too complex to resolve conflicts automatically - so I had to do it manually. It only took me seconds (as I had only googled "git rebase refresh my brain" approx 4 hours ago at work :) :) Had another PR in the "Blank state" series to do too.. not sure why you feel guilty though - it was the great work by @Bakual that messed them up :)
nevermind
i've liked the idea,
didn't suspected to open a small pandora box...
me too lazy
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33334.
Seriously though - your help was much appreciated and this feature is all the more better for your contributions!
It was a pleasure (really!) :)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33334.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33334.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-27 15:30:12 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
Thanks
That's the rename of the layouts. But what about these
$this->get('IsBlankSlate')calls in the if conditions? Will theIsBlankSlatebe renamed, too?