? ? ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
25 Apr 2021

Closes #33312

Steps to reproduce the issue

This PR removes the RSS Feed loading on the Post Installation Messages page.

Reasoning behind this PR

When you view the "Post-installation Messages for Joomla CMS" page, it is always slow-er to load as it has to go out and retrieve and render the RSS feed of release news.

This also doesn't appear to be cached.

"Release news from the Joomla! Project" really has nothing to do with "Post-installation Messages for Joomla CMS"

When viewing "Post-installation Messages for Joomla CMS" there is no reason to be shown what the latest release news is, it has nothing to do with what the messages are.

It would make more sense that a CACHED version of the "Release news from the Joomla! Project" was a toggle-able module on the Home Dashboard (if it must be anywhere).

Screenshot 2021-04-25 at 17 41 18

avatar PhilETaylor PhilETaylor - open - 25 Apr 2021
avatar PhilETaylor PhilETaylor - change - 25 Apr 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Apr 2021
Category Administration com_postinstall
avatar PhilETaylor PhilETaylor - change - 25 Apr 2021
The description was changed
avatar PhilETaylor PhilETaylor - edited - 25 Apr 2021
avatar richard67 richard67 - test_item - 25 Apr 2021 - Tested successfully
avatar richard67
richard67 - comment - 25 Apr 2021

I have tested this item successfully on e1f849c

The PR does what it says.

Question to the community: Shall we add another place in backend where you can see the release notes feed?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33324.

avatar PhilETaylor
PhilETaylor - comment - 25 Apr 2021

Question to the community: Shall we add another place in backend where you can see the release notes feed?

Joomla already alerts if a new version is available... that's good enough :)

avatar PhilETaylor PhilETaylor - change - 25 Apr 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 25 Apr 2021
Category Administration com_postinstall Administration com_postinstall Language & Strings
avatar richard67
richard67 - comment - 25 Apr 2021

after the last change I get a "class 'Factory' not found" error.

avatar PhilETaylor
PhilETaylor - comment - 25 Apr 2021

lol - I blindly trusted @Quy :)

avatar richard67
richard67 - comment - 25 Apr 2021

I don't even trust myself blindly ? .

avatar PhilETaylor
PhilETaylor - comment - 25 Apr 2021

Factory is needed - adding back

avatar Quy
Quy - comment - 25 Apr 2021

Oops. Sorry I see its usage now.

avatar PhilETaylor PhilETaylor - change - 25 Apr 2021
Labels Added: ?
avatar PhilETaylor
PhilETaylor - comment - 25 Apr 2021

Refactored the deprecated method use too :)

<?php if (Factory::getApplication()->getIdentity()->authorise('core.edit.state', 'com_postinstall')) : ?>
avatar richard67 richard67 - test_item - 25 Apr 2021 - Tested successfully
avatar richard67
richard67 - comment - 25 Apr 2021

I have tested this item successfully on 2dfb59d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33324.

avatar dgrammatiko
dgrammatiko - comment - 25 Apr 2021

@PhilETaylor you're deleting my awesome code from 2014 #5222. Well done! kill it with fire ?

avatar dgrammatiko dgrammatiko - test_item - 25 Apr 2021 - Tested successfully
avatar dgrammatiko
dgrammatiko - comment - 25 Apr 2021

I have tested this item successfully on 2dfb59d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33324.

avatar richard67
richard67 - comment - 25 Apr 2021

@dgrammatiko He did not restore the iframe at least ;-)

avatar richard67 richard67 - change - 25 Apr 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 25 Apr 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33324.

avatar Quy Quy - change - 25 Apr 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-04-25 21:47:41
Closed_By Quy
Labels Added: ?
avatar Quy Quy - close - 25 Apr 2021
avatar Quy Quy - merge - 25 Apr 2021
avatar Quy
Quy - comment - 25 Apr 2021

Thank you!

Add a Comment

Login with GitHub to post a comment