[#33323] - [4.0] Media Manager - Can't preview entire image
- Fixed in Code Base
- 30 Apr 2021
- Medium
- Build: 4.0-dev
- # 33323
- Diff
- brianteeman:media_preview
User tests: Successful: Unsuccessful:
Pull request for #29149
This requires npm ci as it's a css change
Steps to reproduce the issue
- Download https://unsplash.com/photos/xnEZYWmfPwU/download?force=true (original size)
- Upload to the Media Manage or place in your images directory
- Double click the image to preview it
Before
Half the image is cropped and you cannot scroll down to view the other half
After
The entire image is visable
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33323.
It is better than before but the entire image is not shown.
Firefox 88.0 & Chrome 90.0.4430.93 on Windows 10
grrrh, works for oversized landscape images but not oversized portrait images
Could you please retest
I have tested this item
Before (changed) Patch, I had the same result as @Quy
(There is no close button, if that doesn't matter)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33323.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33323.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33323.
portrait
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33323.
Please see the close button.
Aha. thks. can't check again, because meanwhile I have overwritten Prebuild Package with Nightly :-)
The close button position has not been changed by this pr
well, maybe I haven't scrolled enough :-) and Yes, we did it together.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33323.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-30 09:56:34 |
| Closed_By | ⇒ | drmenzelit | |
| Labels |
Added:
?
|
||
Thanks
thanks
The SCSS linter complains: