? ? ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
25 Apr 2021

Summary of Changes

Add new blank slate when there are no cached items

Remove toolbar buttons when there is nothing for them to do

Testing Instructions

Apply PR
Go to System -> Cache
See blank state, or see cached items
If you see cached items, delete them all - see blank state
test learn more button

Actual result BEFORE applying this Pull Request

Screenshot 2021-04-25 at 21 22 21

Expected result AFTER applying this Pull Request

Screenshot 2021-04-25 at 21 21 45

Screenshot 2021-04-25 at 21 22 01

Documentation Changes Required

avatar PhilETaylor PhilETaylor - open - 25 Apr 2021
avatar PhilETaylor PhilETaylor - change - 25 Apr 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Apr 2021
Category Administration com_cache Language & Strings
avatar PhilETaylor PhilETaylor - change - 25 Apr 2021
Labels Added: ? ?
avatar richard67
richard67 - comment - 25 Apr 2021

@PhilETaylor What's the name of that new stuff now? The title says "state", the descriptions says "slate".

avatar PhilETaylor
PhilETaylor - comment - 25 Apr 2021

haha "Blank State's Todo #33266" says "state" and blankstate.php is employed - so lets stick to STATE and not slate.

Although probably the wrong term, we should have called it "Empty State" after the UX concept

https://emptystat.es

avatar PhilETaylor PhilETaylor - change - 25 Apr 2021
The description was changed
avatar PhilETaylor PhilETaylor - edited - 25 Apr 2021
avatar richard67
richard67 - comment - 25 Apr 2021

As long as we don't call it "Plank State" ... ;-)

avatar brianteeman
brianteeman - comment - 25 Apr 2021

Same comment as #33328

avatar sandramay0905 sandramay0905 - test_item - 26 Apr 2021 - Tested unsuccessfully
avatar sandramay0905
sandramay0905 - comment - 26 Apr 2021

I have tested this item ? unsuccessfully on 6caaeef

Get no information, no warnings in browser console:

image


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33325.
avatar PhilETaylor
PhilETaylor - comment - 26 Apr 2021

@sandramay0905 No idea how you got that...

avatar joomdonation
joomdonation - comment - 26 Apr 2021

@sandramay0905 @PhilETaylor This PR requires the merged PR #33288 to work. So please update your site to Joomla! 4 nightly build before testing this PR and it should work well.

avatar sandramay0905
sandramay0905 - comment - 26 Apr 2021

@joomdonation

So please update your site to Joomla! 4 nightly build before testing this PR

I installed from launch.joomla.org, this is not based on the nightly builds?

avatar joomdonation
joomdonation - comment - 26 Apr 2021

@sandramay0905 I don't know how launch.joomla.org works, so I could not answer that question. Maybe you can try to apply PR #33288 first, then apply this PR and check the result?

avatar sandramay0905
sandramay0905 - comment - 26 Apr 2021

#33288 isn't shown in patchtester anymore cause its merged.

avatar PhilETaylor
PhilETaylor - comment - 26 Apr 2021

Im on a totally different computer today, in a different location. I pulled this PR's branch and installed Joomla 4, I logged into admin and went to System -> cache and I see it correctly :-)

Screenshot 2021-04-26 at 08 30 13

avatar PhilETaylor
PhilETaylor - comment - 26 Apr 2021

I have also just added the correct icon which will only be displayed after #33332 is merged

Screenshot 2021-04-26 at 08 32 13

avatar brianteeman brianteeman - test_item - 26 Apr 2021 - Tested successfully
avatar brianteeman
brianteeman - comment - 26 Apr 2021

I have tested this item successfully on 4d391e6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33325.

avatar sandramay0905 sandramay0905 - test_item - 26 Apr 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 26 Apr 2021

I have tested this item successfully on 4d391e6

New install at launch.joomla.org did the job :-)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33325.

avatar richard67 richard67 - change - 26 Apr 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 26 Apr 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33325.

avatar PhilETaylor
PhilETaylor - comment - 26 Apr 2021

New install at launch.joomla.org did the job :-)

Sorry we have been very fast moving on this feature over the weekend - its possible the "nightly builds" were in a state of flux as we quickly added new features and they were tested and merged.

Not seen merging activity this fast for many years :)

avatar richard67 richard67 - change - 26 Apr 2021
Status Ready to Commit Pending
avatar richard67
richard67 - comment - 26 Apr 2021

Back to pending. Please alpha-sort the language strings in administrator/language/en-GB/com_cache.ini. It will not need new tests after that.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33325.

avatar PhilETaylor
PhilETaylor - comment - 26 Apr 2021

Thanks - its in my todo list again :)

avatar PhilETaylor PhilETaylor - change - 26 Apr 2021
Labels Added: ?
avatar PhilETaylor
PhilETaylor - comment - 26 Apr 2021

Done.

avatar richard67 richard67 - alter_testresult - 26 Apr 2021 - brianteeman: Tested successfully
avatar richard67 richard67 - alter_testresult - 26 Apr 2021 - sandramay0905: Tested successfully
avatar richard67 richard67 - change - 26 Apr 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 26 Apr 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33325.

avatar PhilETaylor
PhilETaylor - comment - 26 Apr 2021

Please hold off merging this as #33334 will cause this PR to break, so once #33334 is merged I will revisit and fix the language strings etc in this PR.

avatar PhilETaylor PhilETaylor - change - 27 Apr 2021
Labels Removed: ?
avatar PhilETaylor
PhilETaylor - comment - 27 Apr 2021

I have made the rename to EmptyState and this PR is now ready for merging when the checks complete. Thanks.

avatar Quy Quy - change - 27 Apr 2021
Labels Added: ?
avatar PhilETaylor
PhilETaylor - comment - 27 Apr 2021

@Quy - Short Array Syntax is actually against the Joomla Coding Standards.

avatar Quy
Quy - comment - 27 Apr 2021

What? I understand for J3 but it shouldn't be in J4. The short syntax is used plenty elsewhere and this is new code so it will not have impact on the merging from J3 to J4.

avatar PhilETaylor
PhilETaylor - comment - 27 Apr 2021

Im just stating the facts. The Joomla Coding standards suck.

Maybe you missed todays pathetic outcry against my suggestion to fix the Standards and make them modern.

avatar Quy
Quy - comment - 27 Apr 2021

No I have not read it yet. Now I am afraid to. ? J4 is modern so should be its code. I contribute to learn modern techniques and not be burden with the old. FWIW, I agree with you 100%.

avatar PhilETaylor
PhilETaylor - comment - 27 Apr 2021

FWIW, I agree with you 100%.

I've printed out your post and will make a motivational poster of it... Thanks.

avatar Quy
Quy - comment - 27 Apr 2021

This might be out of the scope of this PR. How about adding a button or linking Joomla Global Configuration to Global Configuration > System?

avatar PhilETaylor
PhilETaylor - comment - 27 Apr 2021

The only way I can see to do that is by hard coding the <a href=""></a> tag in the language INI file... are we allowed to do that?

avatar Quy
Quy - comment - 27 Apr 2021

It is allowed, but maybe it would be better to use the button before the Learn more button to link to it.

avatar PhilETaylor
PhilETaylor - comment - 27 Apr 2021

ok well this is RTC so lets leave this one to be merged and when it is I can add the link

avatar PhilETaylor PhilETaylor - change - 28 Apr 2021
Labels Added: ?
Removed: ?
avatar drmenzelit drmenzelit - change - 30 Apr 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-04-30 08:36:31
Closed_By drmenzelit
Labels Added: ?
Removed: ?
avatar drmenzelit drmenzelit - close - 30 Apr 2021
avatar drmenzelit drmenzelit - merge - 30 Apr 2021
avatar drmenzelit
drmenzelit - comment - 30 Apr 2021

Thanks

Add a Comment

Login with GitHub to post a comment