User tests: Successful: Unsuccessful:
Add new blank slate when there are no cached items
Remove toolbar buttons when there is nothing for them to do
Apply PR
Go to System -> Cache
See blank state, or see cached items
If you see cached items, delete them all - see blank state
test learn more button
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_cache Language & Strings |
Labels |
Added:
?
?
|
As long as we don't call it "Plank State" ... ;-)
I have tested this item
Get no information, no warnings in browser console:
@sandramay0905 No idea how you got that...
@sandramay0905 @PhilETaylor This PR requires the merged PR #33288 to work. So please update your site to Joomla! 4 nightly build before testing this PR and it should work well.
So please update your site to Joomla! 4 nightly build before testing this PR
I installed from launch.joomla.org, this is not based on the nightly builds?
@sandramay0905 I don't know how launch.joomla.org works, so I could not answer that question. Maybe you can try to apply PR #33288 first, then apply this PR and check the result?
I have tested this item
I have tested this item
New install at launch.joomla.org did the job :-)
Status | Pending | ⇒ | Ready to Commit |
RTC
New install at launch.joomla.org did the job :-)
Sorry we have been very fast moving on this feature over the weekend - its possible the "nightly builds" were in a state of flux as we quickly added new features and they were tested and merged.
Not seen merging activity this fast for many years :)
Status | Ready to Commit | ⇒ | Pending |
Back to pending. Please alpha-sort the language strings in administrator/language/en-GB/com_cache.ini
. It will not need new tests after that.
Thanks - its in my todo list again :)
Labels |
Added:
?
|
Done.
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Removed:
?
|
I have made the rename to EmptyState and this PR is now ready for merging when the checks complete. Thanks.
Labels |
Added:
?
|
@Quy - Short Array Syntax is actually against the Joomla Coding Standards.
What? I understand for J3 but it shouldn't be in J4. The short syntax is used plenty elsewhere and this is new code so it will not have impact on the merging from J3 to J4.
Im just stating the facts. The Joomla Coding standards suck.
Maybe you missed todays pathetic outcry against my suggestion to fix the Standards and make them modern.
No I have not read it yet. Now I am afraid to.
FWIW, I agree with you 100%.
I've printed out your post and will make a motivational poster of it... Thanks.
This might be out of the scope of this PR. How about adding a button or linking Joomla Global Configuration
to Global Configuration > System?
The only way I can see to do that is by hard coding the <a href=""></a>
tag in the language INI file... are we allowed to do that?
It is allowed, but maybe it would be better to use the button before the Learn more
button to link to it.
ok well this is RTC so lets leave this one to be merged and when it is I can add the link
Labels |
Added:
?
Removed: ? |
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-30 08:36:31 |
Closed_By | ⇒ | drmenzelit | |
Labels |
Added:
?
Removed: ? |
Thanks
@PhilETaylor What's the name of that new stuff now? The title says "state", the descriptions says "slate".