[#33086] - [4.0] Alternative menu
- Fixed in Code Base
- 13 Nov 2021
- Medium
- Build: 4.0-dev
- # 33086
- Diff
- brianteeman:27737
User tests: Successful: Unsuccessful:
PR for #27737
Summary
- Add missing language strings
- Change resources menu link
- Ensure that all utems have the correct url
Testing Before
- Create a new admin menu with the alternative preset and name it test1
- View the list of created menu items
- Observe several missing language strings
- Open the Global Checkin, Clear Cache or System Information menu item
- Observe that Menu Item Type is blank
Testing After Apply PR
- Create a new admin menu with the alternative preset and name it test2
- View the list of created menu items
- Observe no missing language strings
- Open the Global Checkin, Clear Cache or System Information menu item
- Observe that Menu Item Type is completed
Before
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus Language & Strings |
- oops you are correct
- that really confused me but its correct - the extra menu item in test2 is a link to test 1 - do it again and you will have 97
- correct
Thanks for testing
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33086.
Does this PR close your issue? Am asking because it’s still open.
| Labels |
Added:
?
?
|
||
There are still some menu items without Menu Item Type.
Missing language strings:
COM_CONTENT_MENUS_WORKFLOW
COM_MENUS_ITEM_FIELD_TEXT_SEPARATOR_DESC
There are still some menu items without Menu Item Type.
Thats probably because they dont exist
Missing language strings:
COM_CONTENT_MENUS_WORKFLOW
It does exist but it appears to only work in one place
@Quy if your #33086 (comment) is answered can you please test?
I am confused! I see what others have seen but do not understand what is meant by Do it again. In test1 I see COM_USERS_MENUS_USERS in the list and in both Title and Title (en-GB) fields. The menu item type says Menu Heading. In test2 I see Users in the list but the Title contains MOD_MENU_COM_USERS whilst the Title (en-Gb) contains Users. The Menu Item Type is Menu Heading.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33086.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33086.
Hi, I am trying to test this patch but the oldes patch in my list is #33879
Any idea why?
Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33086.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33086.
The PR has good tests but it also has a conflict in file administrator/components/com_menus/presets/alternate.xml so I can't set RTC. But if the conflict is solved cleanly I can do that, no need to test again after that.
| Labels |
Added:
Language Change
?
Removed: ? ? |
||
I've restored the previous test results because the commit which invalidated them was just a clean branch update with a conflict resolution of which I've verified that it was good.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33086.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-11-13 23:15:38 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
|
||
Thx
Thanks
@brianteeman before mark as successfully test questions:
System Informationmenu item has no blank menu item type butGlobal Configurationas you show the screenshot so i guess its only a mistype?COM_USERS_MENUS_USERSandCOM_CONTENT_MENUSmissing language strings > correct?