? Language Change ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
10 Apr 2021

PR for #27737

Summary

  • Add missing language strings
  • Change resources menu link
  • Ensure that all utems have the correct url

Testing Before

  • Create a new admin menu with the alternative preset and name it test1
  • View the list of created menu items
  • Observe several missing language strings
  • Open the Global Checkin, Clear Cache or System Information menu item
  • Observe that Menu Item Type is blank

Testing After Apply PR

  • Create a new admin menu with the alternative preset and name it test2
  • View the list of created menu items
  • Observe no missing language strings
  • Open the Global Checkin, Clear Cache or System Information menu item
  • Observe that Menu Item Type is completed

Before

image

image

avatar brianteeman brianteeman - open - 10 Apr 2021
avatar brianteeman brianteeman - change - 10 Apr 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Apr 2021
Category Administration com_menus Language & Strings
avatar sandramay0905
sandramay0905 - comment - 10 Apr 2021

@brianteeman before mark as successfully test questions:

  1. System Information menu item has no blank menu item type but Global Configuration as you show the screenshot so i guess its only a mistype?
  2. test1 (before pr) has 95, test2 96 menu items > correct?

grafik

  1. found only COM_USERS_MENUS_USERS and COM_CONTENT_MENUS missing language strings > correct?
avatar brianteeman
brianteeman - comment - 10 Apr 2021
  1. oops you are correct
  2. that really confused me but its correct - the extra menu item in test2 is a link to test 1 - do it again and you will have 97
  3. correct
    Thanks for testing
avatar sandramay0905 sandramay0905 - test_item - 10 Apr 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 10 Apr 2021

I have tested this item βœ… successfully on 1e7f576


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33086.

avatar richard67
richard67 - comment - 10 Apr 2021

Does this PR close your issue? Am asking because it’s still open.

avatar brianteeman brianteeman - change - 10 Apr 2021
Labels Added: ? ?
avatar Quy
Quy - comment - 11 Apr 2021

There are still some menu items without Menu Item Type.

Missing language strings:
COM_CONTENT_MENUS_WORKFLOW
COM_MENUS_ITEM_FIELD_TEXT_SEPARATOR_DESC

avatar brianteeman
brianteeman - comment - 11 Apr 2021

There are still some menu items without Menu Item Type.

Thats probably because they dont exist

Missing language strings:
COM_CONTENT_MENUS_WORKFLOW

It does exist but it appears to only work in one place

image

image

avatar sandramay0905
sandramay0905 - comment - 27 Apr 2021

@Quy if your #33086 (comment) is answered can you please test?

avatar ceford
ceford - comment - 8 May 2021

I am confused! I see what others have seen but do not understand what is meant by Do it again. In test1 I see COM_USERS_MENUS_USERS in the list and in both Title and Title (en-GB) fields. The menu item type says Menu Heading. In test2 I see Users in the list but the Title contains MOD_MENU_COM_USERS whilst the Title (en-Gb) contains Users. The Menu Item Type is Menu Heading.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33086.

avatar tw-ekonic tw-ekonic - test_item - 16 Aug 2021 - Tested successfully
avatar tw-ekonic
tw-ekonic - comment - 16 Aug 2021

I have tested this item βœ… successfully on 0da8846


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33086.

avatar BertaOctech
BertaOctech - comment - 3 Sep 2021

Hi, I am trying to test this patch but the oldes patch in my list is #33879

Any idea why?

Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33086.

avatar khu5h1 khu5h1 - test_item - 13 Nov 2021 - Tested successfully
avatar khu5h1
khu5h1 - comment - 13 Nov 2021

I have tested this item βœ… successfully on 0da8846


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33086.

avatar richard67
richard67 - comment - 13 Nov 2021

The PR has good tests but it also has a conflict in file administrator/components/com_menus/presets/alternate.xml so I can't set RTC. But if the conflict is solved cleanly I can do that, no need to test again after that.

avatar brianteeman brianteeman - change - 13 Nov 2021
Labels Added: Language Change ?
Removed: ? ?
avatar richard67 richard67 - alter_testresult - 13 Nov 2021 - tw-ekonic: Tested successfully
avatar richard67 richard67 - alter_testresult - 13 Nov 2021 - khu5h1: Tested successfully
avatar richard67
richard67 - comment - 13 Nov 2021

I've restored the previous test results because the commit which invalidated them was just a clean branch update with a conflict resolution of which I've verified that it was good.

avatar richard67 richard67 - change - 13 Nov 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 13 Nov 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33086.

avatar bembelimen bembelimen - change - 13 Nov 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-11-13 23:15:38
Closed_By bembelimen
Labels Added: ?
avatar bembelimen bembelimen - close - 13 Nov 2021
avatar bembelimen bembelimen - merge - 13 Nov 2021
avatar bembelimen
bembelimen - comment - 13 Nov 2021

Thx

avatar brianteeman
brianteeman - comment - 14 Nov 2021

Thanks

Add a Comment

Login with GitHub to post a comment