Feeling Lucky
?
?
[#33085] - [4.0] Remove unnecessary version compare
- Fixed in Code Base
- 12 Apr 2021
- Medium
- Build: 4.0-dev
- # 33085
- Diff
- joomdonation:patch-5
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
We are on Joomla 4!, so version_compare(\JVERSION, '3.4.0', 'ge') always return true, thus the check could be removed. I found this while trying to look at the the issue with Ftp update
Testing Instructions
Could be merged on review.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate |
| Labels |
Added:
?
|
||
Quy
- comment
- 12 Apr 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33085.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 12 Apr 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33085.
chmst
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-12 18:18:38 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 6c78e44
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33085.