[#33087] - [4.0] webp support in templates
- Fixed in Code Base
- 24 Apr 2021
- Medium
- Build: 4.0-dev
- # 33087
- Diff
- brianteeman:webptemplate
User tests: Successful: Unsuccessful:
#31048 provided the library level support for webp images
This PR adds webp to the list of allowed image types for com_templates. It does not have an update sql as that would change user data.
This isnt really anything to test here accept codestyle as using webp images in templates was the test for the libray update so we know it works
adding support to the media manager will be in its own pr (its a bit more complex)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_templates SQL Installation Postgresql |
I have tested this item
Code style change. All change really does is allow webp images to be used in com_templates.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33087.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33087.
I have tested this item
webp images are saved as jpgs, transparency is lost.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33087.
| Labels |
Added:
?
|
||
To test the resize and cropping of a webp image. Upload an image and resize and/or crop. Then download the image and open in a text editor. If it is still a webp image you will see something like RIFF�"� WEBPVP8 at the beginning. If it has been saved incorrectly as a jpeg then it will have <CREATOR: gd-jpeg v1.0 (using IJG JPEG v90), quality = 100
| Status | Ready to Commit | ⇒ | Pending |
In testing, I also found an issue if the extension of the file is upper case.
sample.PNG would upload, but then not be visible in the file tree. Adding GIF,JPG,JPEG,PNG,WEBP to the list of allowed extensions then allowed the uppercase extension to be viewed.
Is it worth adding that now, or is this something to be raised as a separate issue to fix in the uploader so that it makes the extensions lowercase when the files are uploaded?
Beyond the scope of this PR - please create a separate issue
I have tested this item
Addition of png and webp extensions allows file types to be uploaded.
(To test on existing build check System > Site Templates > Options to add png,webp to the image extensions list, as it won't apply the default automatically)
Resizing and Cropping a webp image saves the image as a webp image correctly.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33087.
I have tested this item
Test OK
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33087.
I have tested this item
Test OK
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33087.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33087.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-24 08:13:38 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
Removed: ? |
||
Thanks
I have tested this item✅ successfully on 7f4cfaa
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33087.