[#3306] - [#33468] Fixes typo in getter and setter of form fields.
- Closed
- 8 Aug 2014
- Medium
- Build: staging
- # 3306
- Diff
- Achal-Aggarwal:typo-get-set
- Foreign ID 33468
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Fixes http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33468&start=0 and similar issues in other field.
I don't quite see what this PR fixes, as there are no issues with the code.
@vdespa Following are the lines in which either $ is before name ($this->name) or is present before protected property ($this->$accept).
- https://github.com/joomla/joomla-cms/pull/3306/files#diff-dec67eea53cfde023707fca26cc69a58L74
- https://github.com/joomla/joomla-cms/pull/3306/files#diff-bad19b858a25cd6463f9c08e6c011b1aL100
- https://github.com/joomla/joomla-cms/pull/3306/files#diff-263feb5d955c0931bea2544b36815f7fL84 (issue reported in 33468)
https://github.com/joomla/joomla-cms/pull/3306/files#diff-037720088ad5e312e2824e27f2cd5550L101 In this inputmode gets a string value instead of boolean.
Other changes are because there is only one property which is present in overridden set & get. So I thought to not to use $name.
The only issue was in JFormFieldTextarea, which already has a PR.
IMHO you are not actually fixing anything, nor are you breaking anything.
The issue Frederic noticed is same as with meter property of password and accept of file field. Try doing the same thing with these fields as described in the joomlacode tracker. Or apply this diff https://gist.github.com/Achal-Aggarwal/9563815#file-typo-password-field-test and run phpunit tests/unit/suites/libraries/joomla/form/fields/JFormFieldPasswordTest.php
closed as per the comment on the tracker
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-08-08 14:36:04 |
@Achal-Aggarwal the password and file field bugs fixed here still exist. would you mind doing a new pr merging in master to fix please? (also as you have a unit test there would be awesome to add that in!)
#3304