Feeling Lucky
?
?
[#3307] - Update TagManager0001Test.php
- Closed
- 1 Apr 2014
- Medium
- Build: staging
- # 3307
- Diff
- kshitijSharma2014:patch-1
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
on line 117 the command was checking whether the tag was in row two but instead of that it was checking that if it was present in row 1.
on line 137 it was checking whether tag that was added its row number should be one but that's not necessary as if there exited some tags already then its row number would be accordingly as it should be but not 1. so now I am just checking here that its row number is greater or equal to 1.
dextercowley
- comment
- 18 Mar 2014
As long as the affected system tests still run, I think this can be merged.
wilsonge
- comment
- 19 Mar 2014
This makes sense to me as well. I guess it's due to the new data schemes that we introduced in 3.2?
javigomez
- comment
- 1 Apr 2014
+1
Merging
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-04-01 16:26:08 |
| Labels | |||
Bakual
-
@kshitij it would be good if you use the same assert at line 117 that you have used on line 137, using greater than equal to makes sense rather than hard coding the rownumber...you cant be sure it is going to be present on 2nd row all the time :)...keep it up!