User tests: Successful: Unsuccessful:
Good job @kshitijSharma2014 ^_^
However we need some updates before having it ready. Specifically the headers and docblocks does not follow our coding standards
Please check our Code Style standards http://joomla.github.io/coding-standards/ (see also http://docs.joomla.org/Coding_style_and_standards)
Set the PHP Code Sniffer in your workstation (see: http://docs.joomla.org/Joomla_CodeSniffer)
Please ping me at skype so we can comment it
Labels |
@javigomez thanks for the above links, they are really helpful. I have installed the JOOMLA! PHP_codesniffer and also I have made the changes in the above file. :)
As long as the affected system tests still run, I think the PR can be merged.
Tested:
phpunit ./services/ConfigFrontEnd0001Test.php
PHPUnit 3.7.29 by Sebastian Bergmann.
Configuration read from /Applications/XAMPP/xamppfiles/htdocs/repos/joomla-cms/tests/system/webdriver/tests/phpunit.xml.dist
.
Time: 11.12 seconds, Memory: 4.00Mb
OK (1 test, 20 assertions)
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-04-15 16:44:02 |
Labels |
@javigomez @puneet0191 I have updated the Config Front end Tests, If you compare this tests class file with others, you will see this was not following the correct pattern. Testing steps were coded in the setup Function unlike other tests, I brought all those things together in the test function and Redesigned the class file.