? ? Success

User tests: Successful: Unsuccessful:

avatar kshitijSharma2014
kshitijSharma2014
14 Mar 2014
avatar kshitijSharma2014 kshitijSharma2014 - open - 14 Mar 2014
avatar kshitijSharma2014
kshitijSharma2014 - comment - 14 Mar 2014

@javigomez @puneet0191 I have updated the Config Front end Tests, If you compare this tests class file with others, you will see this was not following the correct pattern. Testing steps were coded in the setup Function unlike other tests, I brought all those things together in the test function and Redesigned the class file.

avatar puneet0191
puneet0191 - comment - 15 Mar 2014

That is good work!, I am really happy that you not only redesigned it..you also fixed the coding style issues @javier what do u think about this one?

avatar javigomez
javigomez - comment - 18 Mar 2014

Good job @kshitijSharma2014 ^_^

However we need some updates before having it ready. Specifically the headers and docblocks does not follow our coding standards

Please check our Code Style standards http://joomla.github.io/coding-standards/ (see also http://docs.joomla.org/Coding_style_and_standards)
Set the PHP Code Sniffer in your workstation (see: http://docs.joomla.org/Joomla_CodeSniffer)

Please ping me at skype so we can comment it

avatar kshitijSharma2014 kshitijSharma2014 - change - 18 Mar 2014
Labels
avatar kshitijSharma2014
kshitijSharma2014 - comment - 18 Mar 2014

@javigomez thanks for the above links, they are really helpful. I have installed the JOOMLA! PHP_codesniffer and also I have made the changes in the above file. :)

avatar dextercowley
dextercowley - comment - 18 Mar 2014

As long as the affected system tests still run, I think the PR can be merged.

avatar javigomez
javigomez - comment - 15 Apr 2014

Tested:

phpunit ./services/ConfigFrontEnd0001Test.php 
PHPUnit 3.7.29 by Sebastian Bergmann.

Configuration read from /Applications/XAMPP/xamppfiles/htdocs/repos/joomla-cms/tests/system/webdriver/tests/phpunit.xml.dist

.

Time: 11.12 seconds, Memory: 4.00Mb

OK (1 test, 20 assertions)

avatar javigomez javigomez - reference | d224ed4 - 15 Apr 14
avatar javigomez javigomez - merge - 15 Apr 2014
avatar javigomez javigomez - close - 15 Apr 2014
avatar javigomez javigomez - change - 15 Apr 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-04-15 16:44:02
Labels
avatar javigomez javigomez - close - 15 Apr 2014
avatar Bakual Bakual - reference | b2d4cec - 12 May 14

Add a Comment

Login with GitHub to post a comment