Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#32971] - [4] Ensure arrays and objects from a config object can be dumped by cli

? ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
2 Apr 2021

Signed-off-by: Phil E. Taylor phil@phil-taylor.com

Pull Request for Issue #31896

Summary of Changes

Add ability to dump arrays and objects that are in JConfig class when using CLI

Testing Instructions

add the following property to your JConfig class (simulates a profiling session)

public $execution = array('datetime' => '2020-06-29 22:34:47', 'timestamp' => 1593470087, 'microtimestamp' => 1593470087.0546);

php cli/joomla.php config:get

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

The following commands all work with no errors:

 php cli/joomla.php config:get

php cli/joomla.php config:get execution  -vvvv

Documentation Changes Required

none

avatar PhilETaylor PhilETaylor - open - 2 Apr 2021
avatar PhilETaylor PhilETaylor - change - 2 Apr 2021
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Apr 2021
Category ⇒ Libraries
avatar PhilETaylor PhilETaylor - change - 2 Apr 2021
The description was changed
avatar PhilETaylor PhilETaylor - edited - 2 Apr 2021
avatar PhilETaylor PhilETaylor - change - 2 Apr 2021
Title
…
Ensure arrays and objects from a config object can be dumped by cli
[4] Ensure arrays and objects from a config object can be dumped by cli
avatar PhilETaylor PhilETaylor - edited - 2 Apr 2021
avatar toivo toivo - test_item - 3 Apr 2021 - Tested successfully
avatar toivo
toivo - comment - 3 Apr 2021

I have tested this item ✅ successfully on 3a44189

Tested successfully in Beta8-dev of 3 April in Wampserver 3.2.4 using PHP 8.0.2.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32971.

avatar PhilETaylor PhilETaylor - change - 3 Apr 2021
Labels Added: ?
avatar alikon alikon - test_item - 4 Apr 2021 - Tested successfully
avatar alikon
alikon - comment - 4 Apr 2021

I have tested this item ✅ successfully on c386688

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32971.

avatar ceford
ceford - comment - 5 Apr 2021

For me the first test command works but does not include the added line in the output. Is that the expected behaviour? The second command works fine.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32971.

avatar PhilETaylor
PhilETaylor - comment - 5 Apr 2021

@ceford that is correct. Thats expected.

avatar ceford ceford - test_item - 5 Apr 2021 - Tested successfully
avatar ceford
ceford - comment - 5 Apr 2021

I have tested this item ✅ successfully on c386688

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32971.

avatar Quy Quy - change - 5 Apr 2021
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 5 Apr 2021

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32971.

avatar PhilETaylor PhilETaylor - change - 6 Apr 2021
Labels Added: ?
avatar HLeithner HLeithner - close - 8 Apr 2021
avatar HLeithner HLeithner - merge - 8 Apr 2021
avatar HLeithner HLeithner - change - 8 Apr 2021
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-04-08 08:14:28
Closed_By ⇒ HLeithner
Labels Added: ?
Removed: ?
avatar HLeithner
HLeithner - comment - 8 Apr 2021

thanks

Add a Comment

Login with GitHub to post a comment