? ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
2 Apr 2021

Summary of Changes

As composer.json is going to install joomla/ldap and symfonty/ldap it is a requirement of the server to also have the LDAP PHP extension installed and this should be defined as a requirement in the composer.json

Also phpStorm moans if its not defined in the composer.json when viewing the LDAP Packages.

Testing Instructions

Code review.

Actual result BEFORE applying this Pull Request

phpStorm moans:

Screenshot 2021-04-02 at 18 04 51

Composer doesn't moan enough about the missing requirements (like it correctly moans about GD)

Screenshot 2021-04-02 at 18 05 08

Expected result AFTER applying this Pull Request

No Moaning.

Screenshot 2021-04-02 at 18 06 16

Documentation Changes Required

None

avatar PhilETaylor PhilETaylor - open - 2 Apr 2021
avatar PhilETaylor PhilETaylor - change - 2 Apr 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Apr 2021
Category External Library Composer Change
avatar PhilETaylor PhilETaylor - change - 2 Apr 2021
The description was changed
avatar PhilETaylor PhilETaylor - edited - 2 Apr 2021
avatar PhilETaylor PhilETaylor - change - 2 Apr 2021
Labels Added: ? ?
avatar PhilETaylor
PhilETaylor - comment - 2 Apr 2021

The docs are wrong.

This is literally the point of constraints in composer.json

avatar brianteeman
brianteeman - comment - 2 Apr 2021

agree to disagree then

avatar brianteeman
brianteeman - comment - 2 Apr 2021

I am just pointing to the docs that I was pointed to when I reported #32652

avatar PhilETaylor PhilETaylor - close - 2 Apr 2021
avatar PhilETaylor PhilETaylor - change - 2 Apr 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-04-02 22:28:12
Closed_By PhilETaylor

Add a Comment

Login with GitHub to post a comment