? ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
30 Mar 2021

Pull Request for Issue #32917

Summary of Changes

Break out of the foreach loop if we cannot load the update information from the database instead of generating an error message.

Testing Instructions

Joomla 4.0-dev (Enable Debug mode in Joomla Global Config)

Install an old version (only just old!) of Akeeba Backup Core (FREE) from https://www.akeeba.com/download/akeeba-backup/8-0-2/pkg_akeeba-8-0-2-core-zip.zip

Once installed go to:

System -> Update -> Extensions
Click Clear Cache
Click Find Updates
See three available updates
Select ALL THREE UPDATES and click UPDATE..... wait.....

Screenshot 2021-03-28 at 23 02 56

Actual result BEFORE applying this Pull Request

Screenshot 2021-03-28 at 23 06 40

Expected result AFTER applying this Pull Request

Depending on when you test there might be more updates available and found, but you should now at least be able to select a package (Akeeba Backup) and all the other updates, and the package (Akeeba Backup) will update the others (as that's what a package is for - doh!) and the others will not error like they did before.

Screenshot 2021-03-30 at 20 37 42

Documentation Changes Required

None.

Additional comments

// @nikosdion @joomdonation @alikon

avatar PhilETaylor PhilETaylor - open - 30 Mar 2021
avatar PhilETaylor PhilETaylor - change - 30 Mar 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Mar 2021
Category Administration com_installer
avatar PhilETaylor PhilETaylor - change - 30 Mar 2021
The description was changed
avatar PhilETaylor PhilETaylor - edited - 30 Mar 2021
avatar PhilETaylor PhilETaylor - change - 30 Mar 2021
Labels Added: ?
avatar PhilETaylor PhilETaylor - change - 30 Mar 2021
Title
Ensure updates installed by previous package updates dont error
[4] Ensure updates installed by previous package updates dont error
avatar PhilETaylor PhilETaylor - edited - 30 Mar 2021
avatar joomdonation joomdonation - test_item - 31 Mar 2021 - Tested successfully
avatar joomdonation
joomdonation - comment - 31 Mar 2021

I have tested this item successfully on f1303cd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32936.

avatar toivo toivo - test_item - 31 Mar 2021 - Tested successfully
avatar toivo
toivo - comment - 31 Mar 2021

I have tested this item successfully on f1303cd

Tested successfully in Beta8-dev of 30 March in Wampserver 3.2.4 using PHP 8.0.2.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32936.

avatar Quy Quy - change - 31 Mar 2021
Status Pending Ready to Commit
avatar Quy
Quy - comment - 31 Mar 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32936.

avatar PhilETaylor
PhilETaylor - comment - 31 Mar 2021

wow just woke up to see this already at RTC, thanks for testing @joomdonation @toivo @Quy, I appreciate your time.

avatar rdeutz rdeutz - close - 31 Mar 2021
avatar rdeutz rdeutz - merge - 31 Mar 2021
avatar rdeutz rdeutz - change - 31 Mar 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-03-31 06:45:29
Closed_By rdeutz
Labels Added: ?

Add a Comment

Login with GitHub to post a comment