Feeling Lucky
?
?
[#32937] - [3.10] Make sure we follow the inline php cs rules for template files
- Fixed in Code Base
- 18 May 2021
- Medium
- Build: 3.10-dev
- # 32937
- Diff
- zero-24:puc_cleanup
User tests: Successful: Unsuccessful:
Summary of Changes
Make sure we follow the inline php cs rules for template files
Testing Instructions
- Install the latest nighly build of 3.10 from https://developer.joomla.org/nightly-builds.html
- apply this patch.
- install the following extensions:
testuptodatepackage.zip
testuxpackage.zip
testwuj3ej4package.zip
testwuj3n4package.zip
testwuvcpackage.zip
testxupackage.zip - point your Joomla Update Component to
https://update.joomla.org/core/nightlies/next_major_list.xml(Components -> Joomla Update -> Options -> Update Chanel -> Custom)
Actual result BEFORE applying this Pull Request
The pre upgrade checker code has some code that does not fully follow the CS rule for inline php in template files
Expected result AFTER applying this Pull Request
That issue has been patched.
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate |
| Labels |
Added:
?
|
||
brianteeman
- comment
- 1 Apr 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32937.
zero-24
- comment
- 5 May 2021
Changes have been applied, please check again.
Quy
- comment
- 6 May 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32937.
richard67
- comment
- 18 May 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32937.
| Status | Pending | ⇒ | Ready to Commit |
richard67
- comment
- 18 May 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32937.
zero-24
- comment
- 18 May 2021
Merging
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-18 18:28:13 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
|
||
Thanks merged @Quy